Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the option to hide both the task and command lines in the task output #20920

Merged
merged 4 commits into from
Nov 22, 2024

Conversation

omennia
Copy link
Contributor

@omennia omennia commented Nov 20, 2024

The goal is to be able to hide these lines from a task output:

⏵ Task `...` finished successfully
⏵ Command: ...

Here is a video that describes the functionality:
https://github.com/user-attachments/assets/4f17e530-ca53-46df-bbbd-84bcc618ac86
(feel free to watch it in 2x as it's almost 2 minutes long)

Release Notes:

  • Added a way to hide both the task and command lines in the task output

This comment was marked as resolved.

@omennia

This comment was marked as resolved.

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Nov 20, 2024

This comment was marked as resolved.

@maxdeviant maxdeviant changed the title Added the option to hide both the task and command lines in the task output Add the option to hide both the task and command lines in the task output Nov 20, 2024
@notpeter notpeter self-assigned this Nov 20, 2024
- Rename hide_task to show_task
- Rename hide_command to show_command
- Fix comments in terminal.rs
- Update task documentation in tasks.md
@omennia omennia force-pushed the option_task_command_output branch from c66aa16 to 9982279 Compare November 22, 2024 16:50
@notpeter notpeter merged commit 659b1c9 into zed-industries:main Nov 22, 2024
12 checks passed
@notpeter
Copy link
Member

I renamed show_task to show_summary to avoid any confusion, but otherwise this is great!

It'll be available in Zed v0.164.x which will be in Preview Wednesday 2024-11-27 and in Stable the following week!

Thanks and congrats on your first contribution to Zed!

@omennia omennia deleted the option_task_command_output branch November 22, 2024 18:57
@omennia omennia restored the option_task_command_output branch November 22, 2024 18:58
Anthony-Eid pushed a commit to Anthony-Eid/zed that referenced this pull request Nov 22, 2024
…tput (zed-industries#20920)

The goal is to be able to hide these lines from a task output:

```sh
⏵ Task `...` finished successfully
⏵ Command: ...
```

---------

Co-authored-by: Peter Tripp <peter@zed.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed The user has signed the Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants