Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fallback picker ssh fix #21081

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from
Draft

Fallback picker ssh fix #21081

wants to merge 8 commits into from
+75 −24

Conversation

notpeter
Copy link
Member

@notpeter notpeter commented Nov 22, 2024 •
edited
Loading

WIP.

cc: @ConradIrwin

Followup to: #21080

Fix for new_path_prompt not working on remote workspaces.

Steps to reproduce:

  1. cargo run -- ssh://localhost/~/.zshrc
  2. cmd-n, cmd-s enter filename, enter
Screenshot 2024-11-22 at 17 02 48

Release Notes:

  • ssh: Fix for saving new files when first workspace was a non-project workspace

notpeter and others added 4 commits November 21, 2024 13:26
@notpeter
wip
ebff818
@notpeter @ConradIrwin
Fix for the fallback file picker throwing: File exists "os error 17".
81f3aa4 
This was reproducible when the first worktree is a non-folder worktree (e.g. setting.json) so we were trying to create the new file with a path under ~/.config/zed/settings.json/newfile.ext

Co-Authored-By: Conrad Irwin <conrad@zed.dev>
@notpeter
WIP
b46afa7 
Fix for new_path_prompt not working on remote workspaces.

Steps to reproduce:
1. cargo run -- ssh://localhost/~/.zshrc
2. cmd-n, cmd-s enter filename.
@notpeter
remove dbg
c39368f
@notpeter notpeter mentioned this pull request Nov 22, 2024
Merged
@notpeter notpeter added the cla-signed The user has signed the Contributor License Agreement label Nov 23, 2024
@notpeter notpeter mentioned this pull request Nov 26, 2024
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ConradIrwin ConradIrwin

Labels
cla-signed The user has signed the Contributor License Agreement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@notpeter @ConradIrwin