workspace: Implement Extended Terminal Layout

[th0jensen]

Closes #10211

Release Notes:

• Added new layout tree for the bottom dock/terminal to have a full layout that extends below the left and right docks.
• Added configuration under bottom_dock_layout -> "contained" | "full"
• Added button in the terminal toolbar to toggle the behaviour quickly.
• Action (Workspace::ToggleBottomDockLayout)

[mikayla-maki]

What is the source for the expand asset you're using in this PR?

[th0jensen]

What is the source for the expand asset you're using in this PR?

I just asked Zed AI for an SVG that was free to use and would match Zed's other icons in terms of style. I think the decision for which icon to use is ultimately up to you guys, whether this icon fits in or not.

[mikayla-maki]

Wow, the AI did a great job on that icon.

That said, we prefer to use Lucide icons when we need new UI buttons. I added some notes about which ones I think we should use and some implementation details.

[th0jensen]

Thanks for the input on the icons! I moved the property that was on the dock to the workspace, as well as changing out the icons :)

[mikayla-maki]

Awesome! Looks like there's a merge conflict, and could you include a screenshot showing the button you added?

Also, I like that we could add a left-contained setting for this as well, so that only one of the side bars is full width.

[th0jensen]

After adding the left-contained variant I decided to add in both alignments so people can choose what they prefer. So I thought this was the best way to implement the button, but I'm not quite sure. I encountered a lot of "Rustisms" I didn't quite understand, but hey, it runs!

I haven't noticed any weird behaviours or bugs when testing the builds, but I feel like the implementation in crate/terminal_view/terminal_panel.rs is a bit non-optimal.

This is what the button looks like:

[th0jensen]

I also feel like I could use the lucide icon columns-3 and shade which space the bottom bar will occupy. I'd display this next to the labels in the dropdown menu, but it would require adding a new method to crate/ui/context_menu.rs:

The method toggleable_entry() already has a configurable icon: None, so I imagine I could just expose that as a parameter in a different method, something like toggleable_entry_with_icon?

This may be too much effort for a feature that I imagine most people will just configure in settings and leave be...

[mikayla-maki]

Hmm, I think this is a good feature but I don't quite like the look of that menu yet, cc: @danilo-leal, @iamnbutler, how do you think we could incorporate this setting / this UI?

For reference, VSCode uses a button in the top right of the title bar, and that button opens up a menu with an overall layout menu:

[th0jensen]

For reference, VSCode uses a button in the top right of the title bar, and that button opens up a menu with an overall layout menu

I think this makes sense too. It feels unnatural to have the layout control on the dock when the property pertains to the workspace itself- and changing the value does change the button's origin, which is horrible for UX:

If someone wants to change the layout on the current build, they'll have to chase the button around in order to reset or change the layout.

I have noticed that VS Code also has this in the Menu Bar -> View -> Layout (something like this)

[iamnbutler]

While it looks really small, this is a pretty massive change from our standpoint, as all UI in zed thus-far has been designed and build from the perspective of sidebars always extending the full height of the window.

I'm not against us exploring it, but it'll probably have to wait until after the holidays before I can take the time to look into this and give proper feedback.

Thanks for the patience!