Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use warning color for live microphone #22000

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

AaronFeickert
Copy link
Contributor

As noted in #21882, the UI/UX relating to microphone liveness is lacking.

This PR makes a small change that changes the "microphone live" icon to a warning color. This is intended to provide the user some indication of the microphone liveness status.

Release Notes:

  • N/A.

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Dec 14, 2024
@AaronFeickert
Copy link
Contributor Author

At least on macOS, this is consistent with microphone-related warning coloring elsewhere in the operating system.

@mikayla-maki
Copy link
Contributor

Can you include a screenshot of what this looks like?

@AaronFeickert
Copy link
Contributor Author

AaronFeickert commented Dec 14, 2024

Can you include a screenshot of what this looks like?

Yes! It's quite subtle... I would have hoped for something even more obvious:
Screenshot 2024-12-13 at 19 43 27

This uses the Gruvbox Dark theme.

@Angelk90
Copy link

@AaronFeickert : Example of how it does Discord:

Screenshot 2024-12-14 alle 10 24 55 Screenshot 2024-12-14 alle 10 29 07
Registrazione.schermo.2024-12-14.alle.10.26.44.mov

@iamnbutler
Copy link
Member

Active for live mic vs active for muted mic is pretty split across the landscape of VC/communication tools.

After exploring the options when we chose to decorate the muted state, as we felt knowing "for sure" you are muted feels more critical.

CleanShot 2024-12-17 at 08 53 34@2x

I'm not a fan of active styling for default states (which the mic being hot is.)

If we were to style the "live" state of the mic I'd prefer to implement our original design spec where audio activity is indicated in the icon:

CleanShot 2024-12-17 at 08 57 41@2x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed The user has signed the Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants