vim: Add a setting to change the Vim mode indicator position on the status bar from right to left

[helgemahrt]

Add the first request on issue #14093

Release Notes:

• Added a setting to change the Vim mode indicator position on the status bar from right to left

[helgemahrt]

@maxdeviant better now?

[ConradIrwin]

@helgemahrt Thanks for this!

We should put the mode indicator to the left of the diagnostics, otherwise when the diagnostics update the mode indicator jumps around. The tricky bit is that the diagnostics indicator currently provides the vertical line, so we'll need to to fix how that is rendered.

The only reason this is on the right today is this issue, so I'd also be in favor of just moving this to the left unconditionally and saving ourselves a probably unnecessary setting.

[helgemahrt]

IMO it's probably a good idea to have it configurable - there may be people who prefer it on the right side. However, maybe the better approach would be to make the order of all elements of the status bar configurable?

For now, I added a change that ensures that the diagnostics indicator stays the right-most element on the left side of the status bar.

[helgemahrt]

Hang on, I made a mess in this branch when I removed the other commits. I'll create a clean branch/PR and link it here.

[ConradIrwin]

@helgemahrt I think it needs to be the left-most position on the left of the status bar. I don't want it to move when the diagnostics updates.

[helgemahrt]

I think I managed to recover this branch. 😅

@helgemahrt I think it needs to be the left-most position on the left of the status bar. I don't want it to move when the diagnostics updates.

Currently, the diagnostics indicator is the right-most item on the left side, with the vertical separator to the left:

My latest change ensures it stays that way, but, TBH, it feels a bit hacky.

I just realized I missed ensuring that the Vim mode indicator stays behind the diagnostics indicator on startup as well. Will fix that in a moment.

[helgemahrt]

I just realized that there's also the activity indicator. Now I'm thinking that maybe it'd be better to scrap this PR and rethink whether and how the status bar should be configurable. And maybe put the vim mode indicator to the left side for the time being, like you suggested. WDYT?

[ConradIrwin]

Sounds good! If you're up for it I think moving to the left of all the things would be a positive development

[helgemahrt]

Created #22269 to move the indicator. Closing this PR.