Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: Round hover styles for ListItems with outlined set #22120

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

maxdeviant
Copy link
Member

This PR makes ListItems with outlined set use the same rounding for their hover state to ensure that the hover background doesn't bleed outside of the outline.

Release Notes:

  • N/A

@maxdeviant maxdeviant self-assigned this Dec 16, 2024
@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Dec 16, 2024
@maxdeviant maxdeviant merged commit d11deff into main Dec 16, 2024
9 checks passed
@maxdeviant maxdeviant deleted the push-sooyrztrvqzm branch December 16, 2024 23:43
helgemahrt pushed a commit to helgemahrt/zed that referenced this pull request Dec 18, 2024
…tries#22120)

This PR makes `ListItem`s with `outlined` set use the same rounding for
their hover state to ensure that the hover background doesn't bleed
outside of the outline.

Release Notes:

- N/A
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed The user has signed the Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant