Fix no whitespace displaying after an "à " #22403
Open
+11
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixed a bug where with the "show_whitespaces": "boundary" option, when there was an "à" followed by a space, a white space was displayed, and when "à" was at the end of the line, a white space was added
|
We require contributors to sign our Contributor License Agreement, and we don't have @tachyglossues on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'. |
|
@cla-bot check |
cla-bot
bot
added
the
cla-signed
|
The cla-bot has been summoned, and re-checked this pull request! |
maxdeviant
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed a bug where with the "show_whitespaces": "boundary" option, when there was an "à" followed by a space, a white space was displayed, and when "à" was at the end of the line, a white space was added
However, this fix needs to be further investigated because when printing (*line_byte as char) in the terminal, most characters are correctly displayed as they are in Zed. However, certain special characters are considered as multiple characters. Here are some examples with the character written in Zed on the left and the output of (*line_byte as char) on the right:
¨ -> 'Â' '¨'
ù -> 'Ã' '¹'
é -> 'Ã' '©'
√ -> 'â' '\u{88}' '\u{9a}'
♣ -> 'â' '\u{99}' '£'
à -> 'Ã' '\u{a0}'
Unfortunately, I do not have the sufficient knowledge to delve deeper into this issue.