Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ruby: Document use_bundler configuration option #22498

Merged
merged 1 commit into from
Dec 30, 2024

Conversation

vitallium
Copy link
Contributor

Hello,

This PR documents the use_bundler configuration option that was added in https://github.com/zed-extensions/ruby/releases/tag/v0.3.3

What it does?

This option allows users to run solargraph and rubocop within the context of Bundler, which is the most commonly used scenario in the Ruby ecosystem. Ruby LSP is not configured to run in the context of Bundler because it is recommended not to add it to the project dependencies (https://shopify.github.io/ruby-lsp/composed-bundle.html). However, if this is the case, the Ruby LSP can still be configured to run in the context of Bundler via the same configuration option.

This configuration option has the following default values:

  • rubocop - use_bundler is true.
  • solargraph - use_bundler is true.
  • ruby-lsp - use_bundler is false.

Release Notes:

  • N/A

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Dec 30, 2024
@notpeter notpeter added this pull request to the merge queue Dec 30, 2024
@notpeter
Copy link
Member

Excellent. Many thanks.

Merged via the queue into zed-industries:main with commit a119688 Dec 30, 2024
14 checks passed
@vitallium vitallium deleted the vs/update-ruby-doc branch December 31, 2024 06:14
helgemahrt pushed a commit to helgemahrt/zed that referenced this pull request Jan 1, 2025
Hello,

This PR documents the `use_bundler` configuration option that was added
in https://github.com/zed-extensions/ruby/releases/tag/v0.3.3

**What it does?**

This option allows users to run `solargraph` and `rubocop` within the
context of Bundler, which is the most commonly used scenario in the Ruby
ecosystem. Ruby LSP is not configured to run in the context of Bundler
because it is recommended not to add it to the project dependencies
(https://shopify.github.io/ruby-lsp/composed-bundle.html). However, if
this is the case, the Ruby LSP can still be configured to run in the
context of Bundler via the same configuration option.

This configuration option has the following default values:

- `rubocop` - `use_bundler` is `true`.
- `solargraph` - `use_bundler` is `true`.
- `ruby-lsp` - `use_bundler` is `false`.

Release Notes:

- N/A
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed The user has signed the Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants