Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have Zed cli output logs path to stderr #22509

Merged
merged 1 commit into from
Dec 30, 2024
Merged

Have Zed cli output logs path to stderr #22509

merged 1 commit into from
Dec 30, 2024

Conversation

mgsloan
Copy link
Contributor

@mgsloan mgsloan commented Dec 30, 2024

When switching from just running the editor directly to using the CLI I missed the logs in the terminal and started using --foreground. I realized this was because there was a tiny amount of effort involved in finding out where logs were being written to. Having the cli output it to stderr helps make this more visible.

Seems like such a minor thing not listing in release notes.

Release Notes:

  • N/A

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Dec 30, 2024
@mgsloan mgsloan enabled auto-merge December 30, 2024 21:03
@mgsloan mgsloan added this pull request to the merge queue Dec 30, 2024
Merged via the queue into main with commit e9bd4b2 Dec 30, 2024
14 checks passed
@mgsloan mgsloan deleted the path-to-logs-from-cli branch December 30, 2024 21:15
@notpeter
Copy link
Member

notpeter commented Jan 1, 2025

I now get this message on every invocation of zed from the command line.
Screenshot 2025-01-01 at 10 58 51

I think we should revert/refine this.

notpeter added a commit that referenced this pull request Jan 1, 2025
github-merge-queue bot pushed a commit that referenced this pull request Jan 1, 2025
Removes noisy log location stderr output on every `zed` cli invocation.

Reverts #22509

Release Notes:

- N/A
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed The user has signed the Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants