Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure zls is used for Zig as a primary language server #22511

Merged
merged 1 commit into from
Dec 30, 2024

Conversation

SomeoneToIgnore
Copy link
Contributor

@SomeoneToIgnore SomeoneToIgnore commented Dec 30, 2024

Fixes #22415

I've noticed that I cannot work with any Zig projects, as there were no "go to definition", formatting and inlay hints.

After debugging, I've discovered that typos was registered as a first language server, becoming the "primary" one for Zig.
That one does not have any proper capabilities, hence all corresponding LSP requests were no-op.

While this solution is not ideal (I wonder, how many other set-ups are broken due to the same thing?), we'd better fix things for now this way at least.

Release Notes:

  • Fixed zls not working properly when typos extension is installed

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Dec 30, 2024
@SomeoneToIgnore SomeoneToIgnore added this pull request to the merge queue Dec 30, 2024
Merged via the queue into main with commit ddc469c Dec 30, 2024
13 checks passed
@SomeoneToIgnore SomeoneToIgnore deleted the kb/pin-zls branch December 30, 2024 23:36
@SomeoneToIgnore
Copy link
Contributor Author

/cherry-pick v0.167.x

gcp-cherry-pick-bot bot pushed a commit that referenced this pull request Dec 31, 2024
Part of #22415

I've noticed that I cannot work with any Zig projects, as there were no
"go to definition", formatting and inlay hints.

After debugging, I've discovered that `typos` was registered as a first
language server, becoming the "primary" one for Zig.
That one does not have any proper capabilities, hence all corresponding
LSP requests were no-op.

While this solution is not ideal (I wonder, how many other set-ups are
broken due to the same thing?), we'd better fix things for now this way
at least.

Release Notes:

- Fixed `zls` not working properly when `typos` extension is installed
SomeoneToIgnore added a commit that referenced this pull request Dec 31, 2024
…22511) (#22513)

Cherry-picked Ensure zls is used for Zig as a primary language server
(#22511)

Part of #22415

I've noticed that I cannot work with any Zig projects, as there were no
"go to definition", formatting and inlay hints.

After debugging, I've discovered that `typos` was registered as a first
language server, becoming the "primary" one for Zig.
That one does not have any proper capabilities, hence all corresponding
LSP requests were no-op.

While this solution is not ideal (I wonder, how many other set-ups are
broken due to the same thing?), we'd better fix things for now this way
at least.

Release Notes:

- Fixed `zls` not working properly when `typos` extension is installed

Co-authored-by: Kirill Bulatov <kirill@zed.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed The user has signed the Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Zig's formatting doesn't work using editor: format command
1 participant