Enable Blade on MacOS via "macos-blade" feature #7669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cla-bot
bot
added
the
cla-signed
kvark
force-pushed
the
blade
branch
4 times, most recently
from
86ee063 to
50a078e
Compare
|
To test the livestreaming, we have scripts for running multiple Zed instances, but you need to have your enviroment setup a little bit. See the instructions here for more details :D. As for switching the transaction on and off, we added that so resizing works properly. See the details on our blog, particularly the addendum :) |
|
Was able to set up the local server and test the screen sharing with "macos-blade" - all looks good: Gotta admit, it's very appealing as a tool for collaboration! |
kvark
force-pushed
the
blade
branch
4 times, most recently
from
cdf09ed to
f351a06
Compare
|
Dependencies are updated, code is rebased. Please take another look @mikayla-maki ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on zed-industries/font-kit#2 and kvark/blade#77
This change enables Blade to be also used on MacOS. It will also make it easier to use it on Windows.
What works: most of the things. Zed loads as fast and appears equally responsive to the current renderer.
Things missing:
Requires a bit of plumbing on both Blade and Zed sides, but all fairly straightforward.Not sure where exactly to hook up the reaction on the window size change. Once we know where, the fix is one line.Update: I implemented resize support as well as "surface" rendering on the Blade path (which will be useful on Linux/Windows later on). I haven't tested the latter though - not sure how to get something streaming. Would appreciate some help! I don't think this should be a blocker to this PR, anyway.
The only little piece that's missing for the Blade on MacOS path to be full-featured is fine-tuning the CALayer configuration. Zed does a lot of careful logic in configuring the layer, such as switching the "present with transaction" on/off intermittently, which Blade path doesn't have yet.
Release Notes: