Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vulkan linux dependency #8932

Merged
merged 1 commit into from
Mar 7, 2024

Conversation

pigletfly
Copy link
Contributor

@pigletfly pigletfly commented Mar 6, 2024

Release Notes:

Optionally, include screenshots / media showcasing your addition that can be included in the release notes.

or

  • N/A

Signed-off-by: pigletfly <wangbing.adam@gmail.com>
@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Mar 6, 2024
@skullcrushercmd
Copy link
Contributor

i was just compiling it today and was getting that issue, thanks for the fix

@pigletfly
Copy link
Contributor Author

pigletfly commented Mar 6, 2024

after this patch cargo run --release passed, but still some errors exist

[2024-03-06T14:40:54+08:00 ERROR fs] watch path does not exist: ~/.config/zed/keymap.json
[2024-03-06T14:40:54+08:00 ERROR fs] watch path does not exist: ~/.config/zed/settings.json
[2024-03-06T14:40:54+08:00 ERROR util] crates/settings/src/settings_file.rs:76: EOF while parsing a value at line 1 column 0
[2024-03-06T14:40:54+08:00 ERROR util] crates/zed/src/zed.rs:619: EOF while parsing a value at line 1 column 0
[2024-03-06T14:40:54+08:00 ERROR fs] watch path does not exist: ~/.config/zed/tasks.json

@kvark
Copy link
Contributor

kvark commented Mar 6, 2024

#8168 appears to be a collection of different things.
For instance, #8168 (comment) is unlikely going to be resolved by this PR, since the person says they already installed this package.

@pigletfly
Copy link
Contributor Author

#8168 appears to be a collection of different things. For instance, #8168 (comment) is unlikely going to be resolved by this PR, since the person says they already installed this package.

so I will create a new issue instead

@jansol
Copy link
Contributor

jansol commented Mar 6, 2024

Does this really need the -devel package? AFAIK most Rust vulkan bindings don't need that - they only need libvulkan1.

@maxdeviant maxdeviant changed the title Add vulkan linux depend Add vulkan linux dependency Mar 6, 2024
@someone13574
Copy link
Contributor

Does this really need the -devel package? AFAIK most Rust vulkan bindings don't need that - they only need libvulkan1.

No, it doesn’t need it. It is a runtime error, not a build error.

@mikayla-maki mikayla-maki merged commit 35c7b5d into zed-industries:main Mar 7, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed The user has signed the Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants