Fix pre-commit formatting of C++ files #1536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbannier
force-pushed
the
topic/bbannier/clang-format
branch
from
7f8af8b
to
bd61b42
Compare
rsmmr
previously approved these changes
Sep 22, 2023
We would previously files which had _both_ `c` and `c++` types which would only match much fewer files than intended (e.g., `.h` would be classified that way). With this patch we now use `types_or` which combines types with `OR` like we originally intended.
The implementation of the `stray-baselines` hook relies on `btest`. We would previously assume it was installed out of band which makes the default pre-commit hooks cumbersome to use (e.g., opaque failure if dependency missing). This patch explicitly declares the Python dependency which then gets managed by pre-commit. This should come with no new risk as we do not rely on version-dependent BTest features in the hook.
bbannier
force-pushed
the
topic/bbannier/clang-format
branch
from
bd61b42
to
c9f3607
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.