Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a --size parameter to zellij run #3748

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

topisani
Copy link

@topisani topisani commented Nov 8, 2024

This has been an important thing missing for me in automating zellij with kakoune.

Currently, the --size parameter allows either a percentage or an initial row/column count. Importantly, this row/column count does not result in a fixed-size pane, but is just an initial size, that is translated to percentage constraint. This is more useful in my case, but maybe that should be added as a separate SplitSize type instead.

Architecture-wise, this required passing the flag down through a lot of layers, and im unsure if there are better ways to do it.

Additionally, --direction left and --direction up have been fixed, which should close #3332

@topisani
Copy link
Author

topisani commented Nov 8, 2024

@imsnif In the context of your comment, i assume the same applies here. The second commit (direction bug fix) still seems relevant though to me though, right?

@imsnif
Copy link
Member

imsnif commented Nov 8, 2024

Unless I misunderstood you, I don't think the same applies here as this doesn't seem client-specific.

I will however respectfully direct you at: https://github.com/zellij-org/zellij/blob/main/CONTRIBUTING.md#status-of-code-contributions-prs

I once again thank you for your work and willingness to contribute, but this project is large, extremely busy and my capacity is limited. I have to be mindful of my time and attention. I usually prefer solving such issues with larger more sweeping changes.

Thanks again for your understanding.

@topisani
Copy link
Author

topisani commented Nov 8, 2024

this project is large, extremely busy and my capacity is limited. I have to be mindful of my time and attention. I usually prefer solving such issues with larger more sweeping changes.

Fully understand and appreciate that. Feel free to leave this open or close it, however you prefer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't create pannel upward
2 participants