minor changes to 127.1 ,if bitmap is customized #135
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@zemuldo can you please review ? |
zemuldo
requested changes
Sep 18, 2023
| @@ -14,7 +14,14 @@ function assembleKeyValueString(self: ISO8583): DefaultError | Buffer { | |||
| if (mtiCheck && validate && state) { | |||
| const bitmaps_127 = self.assembleBitMap_127(); | |||
| const bmpsHex = self.getBitMapHex_127_ext(); | |||
| let buff = Buffer.alloc(8, bmpsHex, 'hex'); | |||
| const buff = Buffer.alloc(8, bmpsHex, 'hex'); | |||
There was a problem hiding this comment.
This variable is re-assigned, See the failing tests.
There was a problem hiding this comment.
I have made the changes, changed const to let
There was a problem hiding this comment.
@zemuldo would appreciate if you can review and approve if possible ASAP so that I can proceed with my deployment strategy :) Thanks
|
Closing this, duplicate of #137 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
please review the changes