Remove actionpack-action_caching from test setup #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `caches_action` call was added in one of the first commits, when we were testing against Rails 2.3 -- long before actionpack-action_caching was removed from Rails and published as a separate gem. A gem which has not been updated for three years and which is compatible with Rails 6.1 and older.
Makes it easier to configure branch protection rules on GitHub.
bquorning
force-pushed
the
bquorning/remove-actionpack-action_caching
branch
from
99de39b
to
a3c2bd4
Compare
razumau
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
caches_actioncall was added in one of the first commits, when we were testing against Rails 2.3 – long before actionpack-action_caching was removed from Rails and published as a separate gem. A gem which has not been updated for three years and which is compatible with Rails 6.1 and older.