Send exceptions to process_batch instrumenter
#350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deepredsky
approved these changes
Oct 2, 2023
|
@lairen would you be able to add a test to cover this? |
|
@deepredsky done. i also added the specs for the |
lairen
force-pushed
the
fix-process-batch-instrumentation
branch
2 times, most recently
from
4f4509a
to
7be4f0d
Compare
…ception instrumentation
lairen
force-pushed
the
fix-process-batch-instrumentation
branch
from
7be4f0d
to
b392a6c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When exceptions are raised by the processing code in
process_batch, thewith_pausemethod is swallowing them, so the instrumentation does not receive the exceptionThis PR makes it so that the instrumentation receives the processing exceptions.