Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: redo landing page #56

Merged
merged 4 commits into from
Jan 7, 2024
Merged

feat: redo landing page #56

merged 4 commits into from
Jan 7, 2024

Conversation

cabreraalex
Copy link
Member

@cabreraalex cabreraalex commented Jan 5, 2024

Adds a new video, testimonials, and updates structure slightly.

fix ZEN-224

Copy link
Member

@Sparkier Sparkier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to merge from my side since it's already much better compared to before. I have some additional suggestions, though:

  • Video: Really like it overall, I think it's a huge improvement.
    • Can we start with a Zeno screen? This would also act as a separator between loops. Something like this: https://github.com/zeno-ml/zenoml.com/assets/5690524/1dac49d7-6cb8-453b-b068-963d9ef1593c
    • I kinda dislike the purple gradient transition slides. Would it look better if we made them white with purple text or completely purple?
    • The video has a border top and bottom but is cut off left and right. In Screen Studio you can set a resolution for the browser window when recording. Maybe set that to something like 1920 or better 3840 before recording to make sure the aspect is right?
    • The last transition slide is shown too short for the amount of text. I feel like this is the most important message we could show it a bit longer.
    • Can we put the video in a div with rounded corners? This is the only container that does not have them.
  • Not sure about the gradient of the top element following the cursor especially since it jumps around once you hover the video or one of the buttons. Generally feel like either no change or an automatic one over time.
  • Can we add company logos to the endorsements?
  • Should we move sponsors to the footer?
  • Can we swap docs and about in the footer as well?

Copy link

linear bot commented Jan 5, 2024

@cabreraalex
Copy link
Member Author

Updated the video slides (didn't update the actual interaction videos), changed the top gradient to be a slow shift, added logos, swapped footer.

I think sponsors okay where it is for now?

@Sparkier
Copy link
Member

Sparkier commented Jan 6, 2024

two more nits about the video:

  1. it seems like it does not auto-play on chrome
  2. is there a way to show the video controls only on hover? They show for me when the video starts playing by default which is somewhat ugly.

Also do we want to rename "Testimonials"? Maybe "User Feedback" or something like that? Might be just me but testimonials to me sounds more like we asked people to say nice things.

@cabreraalex cabreraalex merged commit 622fd3c into main Jan 7, 2024
1 check passed
@cabreraalex cabreraalex deleted the ac-home-redo branch January 7, 2024 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants