Rearchitecture of Dashboard features #131

maznnwell · 2024-11-05T21:22:04Z

Summary of changes, manly found in the lib/rearchitecture folder:

created a new entry point of the app: main_dev.dart that skips the splash screen; to use this entry point, you can import the run configuration from run_configurations/dev.run.xml
implemented a feature based architecture, using Bloc as state management solution; all the new, or refactored code, will be found in the lib/rearchitecture folder; in a feature based architecture, we create a folder and add all related code to it inside that folder
refactored code and created features to be used in the "Dashboard" tab - with the exception of "Plasma" and "Latest Transactions" widgets that I considered to be part of another mother tab
used HydratedCubits, instead of the inhouse blocs; cubits are lightweight blocs that handle one single job; HydratedCubits cache their last state and restores it
I've added the https://pub.dev/packages/very_good_analysis package for linter rules; it's far more stricter than the previous solution; I haven't solved all the warnings and hints in the app, because that would make my PR too wide in terms of scope
I've created a new version of CardScaffold, one that does not listens to a stream anymore; this new widget also uses the new app themes that are more closer to the default Material Design used by Flutter, especially when it comes to the text styles: I preferred to used the original ones, instead of overwriting them
fixed the switch from the back of the new cards - when active, the thumb was disappearing
fixed the feature of hiding, unhiding the front widget of card (the password field was not being dismissed properly, and the switch was showing that the discreet mode was not active, but front widget was still hidden)
started using localized strings, so it will be easier to translate the app later
added unit tests for the cubits used

The high amount of changes in the folders outside lib/rearchitecture are due to running dart fix --apply, that fixed warnings from the new linter rules. One new rule that I wanted to use specifically, and that generated a lot of changes, is the one that requests strict types when declaring a local variable. I've added comments for this choice in the analysis_options.yaml file

refactor: dashboard blocs

… can specify the state

…ith dart fix --apply

…folder

… new card scaffold

…xtension

Add cubit tests

KingGorrin

Icon has been reset to default flutter icon. See screenshot.
Header font size of new scaffold card is bigger causing a discrepancy between old and new cards. See screenshot.
The Pillar Rewards values in the vertical column do not fit. See screenshot.
Metadata information is not being build. See comments.
App Links support has been removed.

KingGorrin · 2024-11-23T14:28:15Z

windows/CMakeLists.txt

-
-find_program(POWERSHELL_PATH NAMES powershell)
-add_custom_target("git_metadata" ALL
-  COMMAND ${POWERSHELL_PATH} -ExecutionPolicy Bypass "${CMAKE_HOME_DIRECTORY}/CreateGitMetadata.ps1")


Changes from line 97 to 132 causes the build not to copy the necessary binaries library files and the metadata not to be populated with the git information.

Just so you know, this happens on all three platforms. Changes are made to the CMakeLists.txt and project.pbxproj files. I'm not entirely convinced this is the recommended way of doing it.

KingGorrin · 2024-11-23T14:33:34Z

windows/runner/Runner.rc

@@ -89,11 +89,11 @@ BEGIN
    BEGIN
        BLOCK "040904e4"
        BEGIN
-            VALUE "CompanyName", "network.zenon.syrius" "\0"
-            VALUE "FileDescription", "s y r i u s (" VERSION_AS_STRING ")" "\0"
+            VALUE "CompanyName", "com.example" "\0"


Why is the company name changed?

KingGorrin · 2024-11-23T14:34:00Z

windows/runner/Runner.rc

            VALUE "FileVersion", VERSION_AS_STRING "\0"
            VALUE "InternalName", "syrius" "\0"
-            VALUE "LegalCopyright", "(C) 2024 Zenon Network" "\0"
+            VALUE "LegalCopyright", "Copyright (C) 2024 com.example. All rights reserved." "\0"


Why is the LegalCopyright statement changed?

KingGorrin · 2024-11-23T14:38:57Z

windows/runner/resources/app_icon.ico

This overwrites the new syrius icon with the default flutter icon.

KingGorrin · 2024-11-23T14:41:45Z

windows/runner/win32_window.cpp

I believe this file has been manually changed to include support for App Links. The changes remove the App Links support.

…generated Y interval

…indows

maznnwell and others added 30 commits October 10, 2024 13:32

feat: Create dev run configuration

aed7384

refactor: dashboard blocs.

7b18e50

mods: delegation cubit. tests.

f3c2550

mods: delegation cubit - tests.

38853b1

Merge pull request #1 from kossmmos/rearchitecture

ea295c1

refactor: dashboard blocs

Merge branch 'flavors' into rearchitecture

ca4c587

feat: Improve the DashboardCubit class

7eb39c1

feat: Finish the delegation widgets

71a96ac

feat: Use a CardData object to hold the title and description of a card

6c81122

feat: Fill up the balance widgets

fa77953

fix: Assign the correct card data to the CardType.balance value

bd8b12c

feat: Improve the DashboardCubit so that the cubits that implement it…

5930b56

… can specify the state

feat: Fill up the dual coin stats widgets

5c57c1f

fix: Navigate after the current frame finished rendering

70968c3

Merge branch 'flavors' into rearchitecture

6b7ac2e

fix: Apply fixes with dart fix --apply

d67bfa7

fix: Use the super parameters

5f6a0ea

refactor: Replace deprecated methods or classes

4678074

feat: Use very_good_analysis for linter rules and solve some issues w…

e82d7d5

…ith dart fix --apply

feat: Add localization

c47311a

feat: Exemplify how to use AppLocalizations

23cc37b

feat: Enable l10n for the dev entry point also

1367354

fix: Regenerate the windows folder

bfc0836

refactor: Delete unused widgets

594c597

feat: Add documentation of public members inside the dual_coin_stats …

cfa9e26

…folder

feat: Replace Pillars with PillarsCard

6acd44d

feat: Replace RealtimeStatistics with RealtimeStatisticsCard

95746e1

feat: Fill up the sentinels widgets

bebc154

refactor: Change fields' order

c6fff16

fix: Documentation

3e12e56

kossmmos and others added 19 commits October 31, 2024 13:57

node sync status tests added

999734f

feat: Create the new app themes and improve the UI of the back of the…

20ccb84

… new card scaffold

feat: Create a cubit for hiding the front widget of the NewCardScaffold

3317896

feat: Log errors

57dc0fb

feat: Make password field obscure text by default

50a292f

feat: Create the newTheme and isDarkMode getters to the BuildContextE…

b372596

…xtension

feat: Rename local variable

4580937

feat: Delete the font specification from the new themes

fd6f942

fix: Getting setting and getting the new theme

7805614

chore: Rename 'newTheme' getter to 'theme'

ad30daa

feat: Adapt widgets to the new theme data

bed8cd3

chore: Rename getter 'theme' to 'themeData'

de68e9b

Merge pull request #5 from kossmmos/rearchitecture-dashboard

1693811

Add cubit tests

refactor: Cubit initializations

db93609

chore: Use documentation templates for cubit state's fromJson and toJson

14d5699

fix: Some tests

2885d89

chore: Improve documentation

9af0054

feat: Align the text field and the button on the center axis

0d9fe75

chore: Repair dart analysis hints

3b06a48

alienc0der requested review from 0x3639, KingGorrin, vilkris4, digitalSloth and alienc0der November 5, 2024 22:19

maznnwell mentioned this pull request Nov 7, 2024

Add toJson methods, override equals and hashCode methods for some data classes zenon-network/znn_sdk_dart#18

Merged

KingGorrin reviewed Nov 23, 2024

View reviewed changes

KingGorrin added the enhancement New feature or request label Nov 23, 2024

maznnwell added 3 commits November 30, 2024 21:17

feat: Remove styling from left side chart titles and use the default …

bde8cd1

…generated Y interval

feat: Revert some Windows changes

a5a0b85

feat: Associated a custom URL deep linking scheme with the app - on W…

27dfced

…indows

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rearchitecture of Dashboard features #131

Rearchitecture of Dashboard features #131

maznnwell commented Nov 5, 2024

KingGorrin left a comment

KingGorrin Nov 23, 2024

KingGorrin Nov 27, 2024

KingGorrin Nov 23, 2024

KingGorrin Nov 23, 2024

KingGorrin Nov 23, 2024

KingGorrin Nov 23, 2024

Rearchitecture of Dashboard features #131

Are you sure you want to change the base?

Rearchitecture of Dashboard features #131

Conversation

maznnwell commented Nov 5, 2024

KingGorrin left a comment

Choose a reason for hiding this comment

KingGorrin Nov 23, 2024

Choose a reason for hiding this comment

KingGorrin Nov 27, 2024

Choose a reason for hiding this comment

KingGorrin Nov 23, 2024

Choose a reason for hiding this comment

KingGorrin Nov 23, 2024

Choose a reason for hiding this comment

KingGorrin Nov 23, 2024

Choose a reason for hiding this comment

KingGorrin Nov 23, 2024

Choose a reason for hiding this comment