Updated cProps call to use the .items() function of the dictionary …

[dan-smalley]

…to fix the "too many values to unpack" error when attempting to load a device with cProps defined via the Device API router.

(Submitted support ticket 193756 referencing this pull)

Add device job log output pre-patch:

2023-10-12 21:36:06 ERROR zen.zenjobs.job.createdevicejob: Failed to create device.
Traceback (most recent call last):
  File "/opt/zenoss/Products/ZenModel/ZDeviceLoader.py", line 242, in _run
    for prop, value in cProperties:
ValueError: too many values to unpack
2023-10-12 21:36:06 INFO zen.zenjobs.job.createdevicejob: Event sent  event-class-key=zenjobs-failure summary=ValueError: too many values to unpack
2023-10-12 21:36:06 ERROR zen.zenjobs.job.createdevicejob: Job failed: ValueError('too many values to unpack',)

JSON Payload used to test

{
    "action": "DeviceRouter",
    "method": "addDevice",
    "data": [
        {
            "deviceName": "testDevice",
            "deviceClass": "/Discovered",
            "title": "testDevice",
            "collector": "localhost",
            "productionState": 1000,
            "comments": "Device added via API helper script",
            "model": false,
            "cProperties": {"cCMDBCustomRecId":"supercoolrecid","cOwnedByTeam":"supercoolteam"}
        }
    ],
    "type": "rpc",
    "tid": 3
}

[webhookbotuser]

Can one of the admins verify this patch?

[webhookbotuser]

Can one of the admins verify this patch?

[webhookbotuser]

Can one of the admins verify this patch?