Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: ZEN-35044 #4534

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Feature: ZEN-35044 #4534

wants to merge 1 commit into from

Conversation

StevePC
Copy link
Member

@StevePC StevePC commented Aug 28, 2024

No description provided.

jpeacock-zenoss
jpeacock-zenoss requested changes Aug 28, 2024
View reviewed changes
Copy link
Member

@jpeacock-zenoss jpeacock-zenoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like if meta_type attribute is missing from the datamap.target object in one function, it could be missing when accessed in other functions. Perhaps all the occurrences where meta_type is accessed should be updated to access it using getattr?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpeacock-zenoss jpeacock-zenoss jpeacock-zenoss requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@StevePC @jpeacock-zenoss