New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use browser's built-in font parser #11

Merged

zenozeng merged 1 commit into zenozeng:main from Validark:main

Mar 9, 2022

Validark commented Mar 7, 2022 •

edited

Loading

Deletes the messy regular expression in favor of the built-in parser.
- Idea from Font parsing fails on eg 12px/12px gliffy/canvas2svg#68
- Inlines __parseFont and __wrapTextLink methods
Converts remaining tabs to spaces, strips trailing whitespace on each line
- My code editor did this automatically

Fun fact: __fontUnderline and __fontHref allow one to make text underlined and/or linked. This should probably be documented?

Please test before merging!


Use browser's built-in font parser

8a221b2

Validark mentioned this pull request

Should merge fixes from pull requests and issues from gliffy #13

Open

23 tasks

zenozeng merged commit 3573673 into zenozeng:main

Owner

zenozeng commented Mar 9, 2022

@Validark Thanks! Also, I added some rendering test here: #14

https://github.com/zenozeng/svgcanvas/runs/5482063481?check_suite_focus=true

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment