Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop event queues on APNS worker errors #1066

Merged
merged 1 commit into from
Oct 11, 2024
Merged

Conversation

np5
Copy link
Member

@np5 np5 commented Oct 11, 2024

This allows the process to exit gracefully. Otherwise, an event publishing thread might still be running, and the process would not be restarted by systemd for example.

This allows the process to exit gracefully. Otherwise, an event
publishing thread might still be running, and the process would not be
restarted by systemd for example.
Copy link
Collaborator

@headmin headmin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coveralls
Copy link

Pull Request Test Coverage Report for Build 11287388904

Details

  • 7 of 10 (70.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.003%) to 80.822%

Changes Missing Coverage Covered Lines Changed/Added Lines %
zentral/contrib/mdm/workers.py 7 10 70.0%
Totals Coverage Status
Change from base Build 11257727363: -0.003%
Covered Lines: 38465
Relevant Lines: 47592

💛 - Coveralls

@np5 np5 merged commit 8375bd3 into main Oct 11, 2024
10 checks passed
@np5 np5 deleted the 20241011_fix_apns_workers branch October 11, 2024 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants