Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add is_voting_rule #1076

Merged
merged 1 commit into from
Nov 12, 2024
Merged

Add is_voting_rule #1076

merged 1 commit into from
Nov 12, 2024

Conversation

np5
Copy link
Member

@np5 np5 commented Nov 12, 2024

No description provided.

@np5 np5 force-pushed the 20241022_santa_fixed_rules branch from f6219df to 00a9aec Compare November 12, 2024 15:09
@coveralls
Copy link

coveralls commented Nov 12, 2024

Pull Request Test Coverage Report for Build 11801149153

Details

  • 54 of 68 (79.41%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.005%) to 80.865%

Changes Missing Coverage Covered Lines Changed/Added Lines %
zentral/contrib/santa/migrations/0038_rule_is_voting_rule.py 8 22 36.36%
Totals Coverage Status
Change from base Build 11755948592: -0.005%
Covered Lines: 38457
Relevant Lines: 47557

💛 - Coveralls

@np5 np5 force-pushed the 20241022_santa_fixed_rules branch from 00a9aec to 92e7638 Compare November 12, 2024 16:07
Copy link
Collaborator

@headmin headmin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, LGTM!

@np5 np5 merged commit 92e7638 into main Nov 12, 2024
10 checks passed
@np5 np5 deleted the 20241022_santa_fixed_rules branch November 12, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants