Skip to content

Commit

Permalink
#2407 - Remove redundant comments
Browse files Browse the repository at this point in the history
  • Loading branch information
Jeckerson committed Oct 15, 2023
1 parent 7436a5b commit 6cb7efe
Show file tree
Hide file tree
Showing 10 changed files with 2 additions and 59 deletions.
2 changes: 0 additions & 2 deletions Library/Backend/FcallManager.php
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,6 @@ class FcallManager implements FcallManagerInterface
protected array $requiredMacros = [];

/**
* {@inheritdoc}
*
* @param bool $static
* @param int $doReturn tri-state: 0 -> no return value, 1 -> do return, 2 -> do return to given variable
* @param int $paramCount
Expand Down
2 changes: 0 additions & 2 deletions Library/Builder/Operators/AbstractOperatorBuilder.php
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,6 @@ abstract class AbstractOperatorBuilder

/**
* Returns a builder definition.
*
* @return array
*/
abstract public function get(): array;
}
5 changes: 0 additions & 5 deletions Library/Builder/Operators/CastOperatorBuilder.php
Original file line number Diff line number Diff line change
Expand Up @@ -38,11 +38,6 @@ public function __construct(
$this->char = $char;
}

/**
* Returns a builder definition.
*
* @return array
*/
public function get(): array
{
return [
Expand Down
7 changes: 0 additions & 7 deletions Library/Builder/Operators/UnaryOperatorBuilder.php
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,6 @@ class UnaryOperatorBuilder extends AbstractOperatorBuilder
{
/**
* Operator name
*
* @var string
*/
protected string $operator;

Expand All @@ -41,11 +39,6 @@ public function __construct(string $operator, $leftExpression, string $file = nu
$this->char = $char;
}

/**
* Returns a builder definition.
*
* @return array
*/
public function get(): array
{
if (\is_object($this->leftExpression) && method_exists($this->leftExpression, 'get')) {

Check warning on line 44 in Library/Builder/Operators/UnaryOperatorBuilder.php

View check run for this annotation

Codecov / codecov/patch

Library/Builder/Operators/UnaryOperatorBuilder.php#L44

Added line #L44 was not covered by tests
Expand Down
5 changes: 0 additions & 5 deletions Library/Builder/Statements/IfStatementBuilder.php
Original file line number Diff line number Diff line change
Expand Up @@ -28,11 +28,6 @@ public function __construct(
) {
}

/**
* Returns a builder definition.
*
* @return array
*/
public function get(): array
{
$expression = [
Expand Down
5 changes: 0 additions & 5 deletions Library/Builder/Statements/LetStatementBuilder.php
Original file line number Diff line number Diff line change
Expand Up @@ -22,11 +22,6 @@ public function __construct(private array $assignments, private mixed $expr)
{
}

/**
* Returns a builder definition.
*
* @return array
*/
public function get(): array
{
return [
Expand Down
3 changes: 0 additions & 3 deletions Library/Builder/StatementsBlockBuilder.php
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,6 @@ public function __construct(protected array $statements, protected bool $raw = f
{
}

/**
* Returns a builder definition.
*/
public function get(): array
{
if ($this->raw) {
Expand Down
25 changes: 0 additions & 25 deletions Library/Cache/Manager.php
Original file line number Diff line number Diff line change
Expand Up @@ -20,35 +20,18 @@
*/
class Manager
{
/**
* @var FunctionCache|null
*/
protected ?FunctionCache $functionCache = null;

/**
* @var MethodCache|null
*/
protected ?MethodCache $methodCache = null;

/**
* @var StaticMethodCache|null
*/
protected ?StaticMethodCache $staticMethodCache = null;

/**
* @var ClassEntryCache|null
*/
protected ?ClassEntryCache $classEntryCache = null;

/**
* @var CallGathererPass|null
*/
protected ?CallGathererPass $gatherer = null;

/**
* Sets the CallGathererPass.
*
* @param CallGathererPass|null $gatherer
*/
public function setGatherer(CallGathererPass $gatherer = null): void

Check warning on line 36 in Library/Cache/Manager.php

View check run for this annotation

Codecov / codecov/patch

Library/Cache/Manager.php#L36

Added line #L36 was not covered by tests
{
Expand All @@ -57,8 +40,6 @@ public function setGatherer(CallGathererPass $gatherer = null): void

/**
* Creates or returns an existing class entry cache.
*
* @return ClassEntryCache
*/
public function getClassEntryCache(): ClassEntryCache
{
Expand All @@ -71,8 +52,6 @@ public function getClassEntryCache(): ClassEntryCache

/**
* Creates or returns an existing function cache.
*
* @return FunctionCache|null
*/
public function getFunctionCache(): ?FunctionCache
{
Expand All @@ -85,8 +64,6 @@ public function getFunctionCache(): ?FunctionCache

/**
* Creates or returns an existing method cache.
*
* @return MethodCache|null
*/
public function getMethodCache(): ?MethodCache
{
Expand All @@ -99,8 +76,6 @@ public function getMethodCache(): ?MethodCache

/**
* Creates or returns an existing method cache.
*
* @return StaticMethodCache|null
*/
public function getStaticMethodCache(): ?StaticMethodCache
{
Expand Down
1 change: 0 additions & 1 deletion Library/Code/ArgInfoDefinition.php
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@
use Zephir\CompilationContext;
use Zephir\Exception;

use function array_key_exists;
use function Zephir\escape_class;

class ArgInfoDefinition
Expand Down
6 changes: 2 additions & 4 deletions Library/GlobalConstant.php
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,8 @@
* the LICENSE file that was distributed with this source code.
*/

declare(strict_types=1);

namespace Zephir;

/**
Expand All @@ -25,8 +27,6 @@ public function __construct(protected string $name)

/**
* Returns global constant name.
*
* @return string
*/
public function getName(): string

Check warning on line 31 in Library/GlobalConstant.php

View check run for this annotation

Codecov / codecov/patch

Library/GlobalConstant.php#L31

Added line #L31 was not covered by tests
{
Expand All @@ -35,8 +35,6 @@ public function getName(): string

/**
* Check if the global constant is temporal.
*
* @return bool
*/
public function isTemporal(): bool

Check warning on line 39 in Library/GlobalConstant.php

View check run for this annotation

Codecov / codecov/patch

Library/GlobalConstant.php#L39

Added line #L39 was not covered by tests
{
Expand Down

0 comments on commit 6cb7efe

Please sign in to comment.