libraries: SPI: Hanlde multiple SPI instances #113
Conversation
soburi
changed the title
libraries/SPI/SPI.cpp
Outdated
| arduino::ZephyrSPI | ||
| SPI(DEVICE_DT_GET(DT_PHANDLE_BY_IDX(DT_PATH(zephyr_user), spis, 0))); | ||
| #endif // HAS_PORP(i2cs) |
There was a problem hiding this comment.
Pardon me, I didn't understand how I2C has any relevance here in SPI.cpp?
There was a problem hiding this comment.
Sorry, I verified the code but forgot to edit the comment. I'm using the structure that was originally used for I2C.
libraries/SPI/SPI.cpp
Outdated
| arduino::ZephyrSPI | ||
| SPI(DEVICE_DT_GET(DT_PHANDLE_BY_IDX(DT_PATH(zephyr_user), spis, 0))); | ||
| #endif // HAS_PORP(i2cs) | ||
| /* If i2cs node is not defined, tries to use arduino_i2c */ |
There was a problem hiding this comment.
s/arduino_i2c/arduino_spi ?
|
I'm going to put it back into draft because I have some concerns. Sorry. |
soburi
force-pushed
the
multiple_spi
branch
2 times, most recently
from
ad8d4c0
to
4ce81ce
Compare
There was a problem hiding this comment.
@soburi nothing against this PR, but can you add more in your commit about how this change helps us/ what feature it enables? Talk about what enhancement this is bringing in basically.
|
Also, |
| arduino::ZephyrSPI | ||
| SPI(DEVICE_DT_GET(DT_PHANDLE_BY_IDX(DT_PATH(zephyr_user), spis, 0))); | ||
| #endif // HAS_PORP(spis) | ||
| /* If spis node is not defined, tries to use arduino_spi */ | ||
| #elif DT_NODE_EXISTS(DT_NODELABEL(arduino_spi)) |
There was a problem hiding this comment.
So where does the arduino-spi name come from? Are any boards already defining it using that label?
There was a problem hiding this comment.
It is usually define with arduino_header in zephyr/boards definitions.
This line is intended to take advantage of it if it is already defined.
And we can override with overlay in this package with defining spis property.
soburi
force-pushed
the
multiple_spi
branch
2 times, most recently
from
5aa3007
to
bc7cf72
Compare
Added description to commit message.
Fixed it. Thank you. |
@soburi Nope, I still see the wrong spelling in subject. https://github.com/zephyrproject-rtos/gsoc-2022-arduino-core/pull/113/commits |
| #define DECL_EXTERN_SPI_N(i) extern arduino::ZephyrSPI SPI##i; | ||
| #define DECLARE_EXTERN_SPI_N(n, p, i) \ | ||
| COND_CODE_1(ARDUINO_SPI_DEFINED_##i, (DECL_EXTERN_SPI_0(i)), (DECL_EXTERN_SPI_N(i))) | ||
|
|
There was a problem hiding this comment.
Please fix above checkpatch warns @soburi .
WARNING: please, no spaces at the start of a line
There was a problem hiding this comment.
Was this fixed?
Can you please fix, rebase and force push if not done?
soburi
force-pushed
the
multiple_spi
branch
2 times, most recently
from
f9d18ce
to
658e88c
Compare
| #define DECL_EXTERN_SPI_N(i) extern arduino::ZephyrSPI SPI##i; | ||
| #define DECLARE_EXTERN_SPI_N(n, p, i) \ | ||
| COND_CODE_1(ARDUINO_SPI_DEFINED_##i, (DECL_EXTERN_SPI_0(i)), (DECL_EXTERN_SPI_N(i))) | ||
|
|
There was a problem hiding this comment.
Was this fixed?
Can you please fix, rebase and force push if not done?
Create multiple SPI instances if the `spis` array contains plural elements. Declare these as 'SPI1', 'SPI2', ..., from the second element of the array. (The first element is already declared as 'SPI'.) If `spis` is not defined but the DTS already defines `arduino-spi` and, use it to define the first SPI instance. The `arduion-spi` is usually defined with arduino_header in boards definitions. Signed-off-by: TOKITA Hiroshi <tokita.hiroshi@gmail.com>
Create multiple SPI instance if spis array contains plural elements. Declare these as 'SPI1', 'SPI2', ..., from second element of the array. (First element is already declare as 'SPI'.)