-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement interrupts and noInterrupts #119
Conversation
b382d4b
to
d3ea35d
Compare
675628e
to
9e2947b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have defined interrupts()
/ noInterrupts()
only in common.cpp
. How will anyone outside of this file ever use it? Using it in some example would be great.
These function prototypes don't exist in the Arduino Core API.
See how SAMD has done it: https://github.com/arduino/ArduinoCore-samd/blob/993398cb7a23a4e0f821a73501ae98053773165b/cores/arduino/Arduino.h#L53
Is there a reason to use macro instead of just adding function prototype to |
Nope, not atall. I just meant to show that they have exposed it via the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for addressing all comments.
Can you please rebase and force push? |
- Using irq_lock and irq_unlock zephyr apis. Signed-off-by: Ayush Singh <ayush@beagleboard.org>
Common.h
has the following line: