middleware: wifi_nxp: add wifi driver #416
Conversation
Add wifi driver code. Signed-off-by: Maochen Wang <maochen.wang@nxp.com>
|
Hi @dleach02 @mmahadevan108 please review this wifi core driver |
mmahadevan108
requested review from
mmahadevan108,
dleach02,
danieldegrasse and
decsny
There was a problem hiding this comment.
A few general requests related to folders we can remove:
- can we remove the
clifolder? - are we enabling DHCP server support in Zephyr? If not, can we remove the
dhcpdfolder? - we should remove the
examplefolder - we should drop the
internalfolder - binary files in
libneed to be removed (likely just remove the folder, we can't have binary files) - we should drop the
nw_utilsfolder andtelentfolder - binary firmware blobs in
fw_binsneed to be dropped, we need to add support for pulling these in viawest blobsby defining the URL to pull them from in the module.yml file: https://github.com/zephyrproject-rtos/hal_nxp/blob/master/zephyr/module.yml#L9
Also, what is the code for sigma_agent? If this is a sample/test application, we should not ship it with our HAL driver code
| @@ -0,0 +1,65 @@ | |||
| const unsigned char ca_der[] = { | |||
There was a problem hiding this comment.
From what I can tell, these files are being used for WPA enterprise support? Are these files something that needs to be configured for customer applications, or are they hardcoded?
There was a problem hiding this comment.
these are as an example, can be used or just generated by cmd (our user manual has the steps to generate)
There was a problem hiding this comment.
Ok, is there a way to replace these files in a build without editing them? IE can the user set a new path to these files using a KConfig or CMake variable? We should not require users to modify the NXP HAL in order to generate different CA certificates
There was a problem hiding this comment.
there is way to generate, and merged upstream in Zephyr, but not verified downstream. so currently we keep this old way to use. Maybe in the future can remove this.
There was a problem hiding this comment.
This file is zephyr specific since it uses the SDIO APIs. Do we want to include the FreeRTOS version of this file as well, so we can use a single source tree for FreeRTOS and Zephyr?
There was a problem hiding this comment.
this needed for rt platform
There was a problem hiding this comment.
Sure- what I'm asking is if we want to have a "zephyr" version and "freertos" version of this file. The advantage of this would be that we can use one source tree for the WIFI NXP driver, and not need to release a "zephyr" version of this file and "freertos" version
There was a problem hiding this comment.
this wifi_nxp code/branch is specific for zephyr, and all the freertos related are removed
| #include <mlan_sdio_api.h> | ||
| #include <osa.h> | ||
| #include <fsl_common.h> | ||
| #include <fsl_gpio.h> |
There was a problem hiding this comment.
No need for the fsl_xx includes here, right?
There was a problem hiding this comment.
these are needed for sdio case
There was a problem hiding this comment.
Am I missing somewhere in this file where we use FSL APIs? We should not do this- we want to make sure the SDIO code can run on non-nxp platforms, so we should use Zephyr APIS, not SDK APIs.
There was a problem hiding this comment.
@MaochenWang1 ping on this question
|
@MaochenWang1 we need a Zephyr side PR that brings this in |
Add wifi driver code inside the hal_nxp.