Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STM32WBA 1.3.1 Cube FW Updates Integration #214

Merged
merged 6 commits into from
Jun 7, 2024
Merged

STM32WBA 1.3.1 Cube FW Updates Integration #214

merged 6 commits into from
Jun 7, 2024

Conversation

asm5878
Copy link

@asm5878 asm5878 commented May 31, 2024

Integration of HAL/LL/BLE updates from STM32WBA Cube FW 1.3.1

Copy link
Member

@erwango erwango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments but other wise looks good overall.

Also:

  • Please add a commit message in each commit
  • Please split last commit into individual changes

stm32cube/stm32wbaxx/CMakeLists.txt Outdated Show resolved Hide resolved
stm32cube/stm32wbaxx/README Outdated Show resolved Hide resolved
lib/stm32wba/hci/README Outdated Show resolved Hide resolved
stm32cube/common_ll/README.rst Show resolved Hide resolved
lib/stm32wba/hci/app_conf.h Show resolved Hide resolved
zephyr/module.yml Show resolved Hide resolved
@asm5878
Copy link
Author

asm5878 commented Jun 5, 2024

Branch updated with the suggested changes.
Could you please review, thanks!

Copy link
Member

@erwango erwango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last minor change and this will be fine to me

lib/stm32wba/hci/pta.h Show resolved Hide resolved
@erwango erwango requested review from marwaiehm-st and gautierg-st and removed request for marwaiehm-st June 6, 2024 11:16
lib/stm32wba/hci/pta.h Outdated Show resolved Hide resolved
Copy link
Collaborator

@gautierg-st gautierg-st left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one file to remove + @marwaiehm-st comments, otherwise LGTM

asm5878 added 6 commits June 6, 2024 16:59
Update Cube version for STM32WBAxx series
on https://github.com/STMicroelectronics
from version v1.2.0
to version v1.3.1

Signed-off-by: Alessandro Manganaro <alessandro.manganaro@st.com>
Update Cube version for STM32WBAxx series
on https://github.com/STMicroelectronics
from version v1.2.0
to version v1.3.1

Signed-off-by: Alessandro Manganaro <alessandro.manganaro@st.com>
Re - generate common_ll headers after Cube updates

Signed-off-by: Alessandro Manganaro <alessandro.manganaro@st.com>
Solving conflict in IRQ check on specific BLE use cases

Signed-off-by: Alessandro Manganaro <alessandro.manganaro@st.com>
Adding Packet Traffic Arbitration API
Missing file after cube stm32wba version 1.3.1 update

Signed-off-by: Alessandro Manganaro <alessandro.manganaro@st.com>
Binary Link Layer 1.3.1 library update for the STM32WBA Bluetooth
Binary Stack 1.3.1 library update for the STM32WBA Bluetooth

Signed-off-by: Alessandro Manganaro <alessandro.manganaro@st.com>
@asm5878
Copy link
Author

asm5878 commented Jun 6, 2024

Dear All,
Here my new iteration.
Thanks for your feedback

@marwaiehm-st
Copy link
Collaborator

LGTM

@erwango erwango merged commit f97d00b into zephyrproject-rtos:main Jun 7, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants