lib: fix strncpy usage #21
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjarki-andreasen
added a commit
to bjarki-andreasen/sdk-zephyr
that referenced
this pull request
Sep 23, 2024
This should be removed once zephyrproject-rtos/open-amp#21 is merged. Signed-off-by: Bjarki Arge Andreasen <bjarki.andreasen@nordicsemi.no>
This was referenced Sep 23, 2024
bjarki-andreasen
added a commit
to bjarki-andreasen/sdk-zephyr
that referenced
this pull request
Sep 23, 2024
This should be removed once zephyrproject-rtos/open-amp#21 is merged. Signed-off-by: Bjarki Arge Andreasen <bjarki.andreasen@nordicsemi.no>
bjarki-andreasen
added a commit
to bjarki-andreasen/sdk-zephyr
that referenced
this pull request
Sep 24, 2024
This should be removed once zephyrproject-rtos/open-amp#21 is merged. Signed-off-by: Bjarki Arge Andreasen <bjarki.andreasen@nordicsemi.no>
bjarki-andreasen
added a commit
to bjarki-andreasen/sdk-zephyr
that referenced
this pull request
Sep 24, 2024
This should be removed once zephyrproject-rtos/open-amp#21 is merged. Signed-off-by: Bjarki Arge Andreasen <bjarki.andreasen@nordicsemi.no>
bjarki-andreasen
added a commit
to bjarki-andreasen/sdk-zephyr
that referenced
this pull request
Sep 24, 2024
This should be removed once zephyrproject-rtos/open-amp#21 is merged. Signed-off-by: Bjarki Arge Andreasen <bjarki.andreasen@nordicsemi.no>
bjarki-andreasen
approved these changes
Sep 24, 2024
bjarki-andreasen
added a commit
to bjarki-andreasen/sdk-zephyr
that referenced
this pull request
Sep 25, 2024
This should be removed once zephyrproject-rtos/open-amp#21 is merged. Signed-off-by: Bjarki Arge Andreasen <bjarki.andreasen@nordicsemi.no>
bjarki-andreasen
added a commit
to bjarki-andreasen/sdk-zephyr
that referenced
this pull request
Sep 25, 2024
This should be removed once zephyrproject-rtos/open-amp#21 is merged. Signed-off-by: Bjarki Arge Andreasen <bjarki.andreasen@nordicsemi.no>
bjarki-andreasen
added a commit
to bjarki-andreasen/sdk-zephyr
that referenced
this pull request
Sep 27, 2024
This should be removed once zephyrproject-rtos/open-amp#21 is merged. Signed-off-by: Bjarki Arge Andreasen <bjarki.andreasen@nordicsemi.no>
bjarki-andreasen
added a commit
to bjarki-andreasen/sdk-zephyr
that referenced
this pull request
Sep 27, 2024
This should be removed once zephyrproject-rtos/open-amp#21 is merged. Signed-off-by: Bjarki Arge Andreasen <bjarki.andreasen@nordicsemi.no>
bjarki-andreasen
added a commit
to bjarki-andreasen/sdk-zephyr
that referenced
this pull request
Sep 27, 2024
This should be removed once zephyrproject-rtos/open-amp#21 is merged. Signed-off-by: Bjarki Arge Andreasen <bjarki.andreasen@nordicsemi.no>
bjarki-andreasen
added a commit
to bjarki-andreasen/sdk-zephyr
that referenced
this pull request
Sep 30, 2024
This should be removed once zephyrproject-rtos/open-amp#21 is merged. Signed-off-by: Bjarki Arge Andreasen <bjarki.andreasen@nordicsemi.no>
tomi-font
changed the title
tomi-font
force-pushed
the
cherry_pick_strncpy_fix
branch
2 times, most recently
from
2e8faee
to
1686dbd
Compare
tomi-font
changed the title
tejlmand
suggested changes
Sep 30, 2024
There was a problem hiding this comment.
Open-amp PRs cannot been directly on top of the Zephyr open-amp fork, because the open-amp project is being filtered (apps folder removed) and placed in a sub-folder named open-amp, thus any upstream open-amp PRs must be manually adjusted to work.
See also:
https://github.com/zephyrproject-rtos/open-amp/blob/master/README
https://github.com/zephyrproject-rtos/open-amp/tree/master
Origin: OpenAMP/open-amp#620 Commits: e233473d14654f08468595ad0dbe8f7e58acf267 8591566382d055acd33f9d23e6826a8a4b0a1881 1aecdc737d463b4ff1ece36847f4f2e68d4ffe4a Status: Cherry pick PR that fixes the `stringop-truncation` compilation errors due to former usage of `strncpy()`. Signed-off-by: Tomi Fontanilles <tomi.fontanilles@nordicsemi.no>
tomi-font
force-pushed
the
cherry_pick_strncpy_fix
branch
from
1686dbd
to
9fef9fd
Compare
|
Ah right, thanks for noticing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry picks from upstream PR OpenAMP/open-amp#620.
This fixes
stringop-truncationcompilation errors.