grep: fix command hanging forever when grep.{tool}-args is empty #681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes commit 1d220bb ("commands: add grep") Fix misplaced closing parenthese in: ``` shlex.split(self.config.get(f'grep.{tool}-args'), '') ``` The empty string is meant as a default value for config.get() but it was passed as a second argument to shlex.split() by mistake. Funny enough this hangs forever: ``` >>> shlex.split(None, comments='') <stdin>:1: DeprecationWarning: Passing None for 's' to shlex.split() is deprecated. (hangs forever) ``` PS: debuggers rulez Signed-off-by: Marc Herbert <marc.herbert@intel.com>
Merged
mbolivar-ampere
approved these changes
Aug 31, 2023
|
Because I have no Mystery solved: that's because the (complex) tox+pytest test environment closes the standard input. In fact a workaround for this bug is to hit I can see that the test environment solves a lot of problems. But it also creates some distance and divergence with the real thing. I just tried to document this gap here: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes commit 1d220bb ("commands: add grep") / #678
Fix misplaced closing parenthese in:
The empty string is meant as a default value for config.get() but it was passed as a second argument to shlex.split() by mistake.
Funny enough this hangs forever:
PS: debuggers rulez