Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

app: Add -q argument for quiet mode #723

Merged
merged 1 commit into from
Aug 30, 2024
Merged

Conversation

pdgendt
Copy link
Collaborator

@pdgendt pdgendt commented Jul 22, 2024

Add a west argument to set verbosity to the quiet mode

src/west/app/main.py Outdated Show resolved Hide resolved
src/west/app/main.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@marc-hb marc-hb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't you need to update src/west/log.py too? See commit 7eb1126

@pdgendt
Copy link
Collaborator Author

pdgendt commented Aug 28, 2024

Don't you need to update src/west/log.py too? See commit 7eb1126

I was reluctant for changing the deprecated functions, but I think some minimal changes can be done. Updated.

Copy link
Collaborator

@marc-hb marc-hb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was reluctant for changing the deprecated functions,

As long as they are present and in use then they should behave the same, otherwise the experience is inconsistent.

but I think some minimal changes can be done.

I didn't expect any major change either, otherwise I would have thought twice before asking.

src/west/app/main.py Outdated Show resolved Hide resolved
src/west/commands.py Outdated Show resolved Hide resolved
Add a west argument to decrease the verbosity.

Signed-off-by: Pieter De Gendt <pieter.degendt@basalte.be>
@marc-hb marc-hb merged commit 0612a6d into zephyrproject-rtos:main Aug 30, 2024
9 checks passed
@pdgendt pdgendt deleted the quiet branch August 30, 2024 17:36
@pdgendt pdgendt added this to the v1.3.0 milestone Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants