Add docker compose based test environment for Linux #733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it trivial to inspect, line by line, what got covered. That is useful when evaluating coverage for a new feature. Signed-off-by: Martí Bolívar <mbolivar@amperecomputing.com>
pdgendt
force-pushed
the
docker-compose
branch
from
7d226d4
to
8776599
Compare
|
@marc-hb any objections to this PR? I found it very useful to run these extensive tests locally without the need for a lot of manuals setups. |
marc-hb
reviewed
Sep 23, 2024
marc-hb
reviewed
Sep 23, 2024
There was a problem hiding this comment.
It doesn't change the source code or packages.
Short of using a separate repository (admittedly a bit overkill but see why in #687 (comment)), please make sure Docker stuff stays contained in a separate sub directory.
pdgendt
force-pushed
the
docker-compose
branch
2 times, most recently
from
9b63579
to
72b695d
Compare
|
@marc-hb reduced to mostly reusable files and yaml sections |
marc-hb
approved these changes
Sep 24, 2024
Our release process documentation recommends getting passing tox results on as many popular linux distributions as time allows. Doing this by hand is cumbersome, redundant, and error prone. Add a directory with a helper script that automates the entire process using docker compose and document its use in MAINTAINERS.rst. Signed-off-by: Martí Bolívar <mbolivar@amperecomputing.com> Signed-off-by: Pieter De Gendt <pieter.degendt@basalte.be>
pdgendt
force-pushed
the
docker-compose
branch
from
72b695d
to
89e9dc8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated #687 as it appeared to be stale, but still useful.