manifest: Add submodule representation in as_dict #740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pdgendt
force-pushed
the
project-submodules
branch
from
9059122
to
c3745b6
Compare
pdgendt
force-pushed
the
project-submodules
branch
2 times, most recently
from
965e3a2
to
6b6a516
Compare
marc-hb
reviewed
Sep 23, 2024
Submodules were missing when calling --freeze or --resolve Signed-off-by: Pieter De Gendt <pieter.degendt@basalte.be>
Add a minimal testing to validate submodule output for manifest --freeze Signed-off-by: Pieter De Gendt <pieter.degendt@basalte.be>
Add a testcase to parse a manifest and validate the as_dict output. Add an invalid manifest file for missing required submodule properties. Signed-off-by: Pieter De Gendt <pieter.degendt@basalte.be>
pdgendt
force-pushed
the
project-submodules
branch
from
6b6a516
to
46d36fd
Compare
marc-hb
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submodules were missing when calling --freeze or --resolve
Fixes #739