tests: config: Fix assertions checks with pytest.raises #777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marc-hb
previously approved these changes
Jan 5, 2025
|
@carlescufi #768 might change the message with the grouped argument change, this PR can go before or after yours but might need changes accordingly. |
pdgendt
force-pushed
the
fix-assert-raises
branch
from
62a7753 to
41f201b
Compare
|
Updated after merging #768 with updated error messages. |
marc-hb
reviewed
Jan 7, 2025
There was a problem hiding this comment.
I took a longer look and realized now that this does much more than moving the asserts : this also fixes the test code which of course did not work because it never ran!
That's great, but now I see a lot of repetition. Have you considered a new, generic function for negative tests? Something like:
def run_bad_cmd(cmd_str_or_list, expected_exception_type):
with pytest.raises(expected_exception_type) as e:
...
return err_msg
emsg = run_bad_cmd("config pytest", subprocess.CalledProcessError)
assert 'invalid ..." in emsg
Create a helper function that captures an expected exception and returns the output together with stderr data. Dedent assertion checks as they were currently skipped, and make sure the correct error message is validated. Signed-off-by: Pieter De Gendt <pieter.degendt@basalte.be>
pdgendt
force-pushed
the
fix-assert-raises
branch
from
41f201b to
5b12276
Compare
marc-hb
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dedent assertion checks as they were currently skipped, and make sure the correct error message is validated.
Fixes #776