Skip to content

ili9341: mipi-dbi-mode setable through DT #149694

ili9341: mipi-dbi-mode setable through DT

ili9341: mipi-dbi-mode setable through DT #149694

Triggered via pull request September 17, 2024 07:20
Status Failure
Total duration 2m 38s
Artifacts 1

compliance.yml

on: pull_request
Run compliance checks on patch series (PR)
2m 29s
Run compliance checks on patch series (PR)
Fit to window
Zoom out
Zoom in

Annotations

4 errors, 1 warning, and 1 notice
Run compliance checks on patch series (PR)
Process completed with exit code 3.
Run compliance checks on patch series (PR): Identity.txt#L1
See https://docs.zephyrproject.org/latest/contribute/guidelines.html#commit-guidelines for more details 99bb707a9d2070c2b49d5a46823a8fef63d59f66: author email (Thorsten Spätling <thorsten.spaetling@vierling.de>) needs to match one of the signed-off-by entries.
Run compliance checks on patch series (PR): Gitlint.txt#L1
See https://docs.zephyrproject.org/latest/contribute/guidelines.html#commit-guidelines for more details 1: UC2 Commit message does not contain a 'Signed-off-by:' line 1: UC6 Commit message body is empty, should at least have 1 line(s). 3: B6 Body message is missing
Run compliance checks on patch series (PR)
Process completed with exit code 1.
Run compliance checks on patch series (PR): ClangFormat.txt#L1
See https://docs.zephyrproject.org/latest/contribute/guidelines.html#clang-format for more details. You may want to run clang-format on this change: -#define ILI9XXX_INIT(n, t) \ - ILI##t##_REGS_INIT(n); \ - \ - static const struct ili9xxx_config ili9xxx_config_##n = { \ - .quirks = &ili##t##_quirks, \ - .mipi_dev = DEVICE_DT_GET(DT_PARENT(INST_DT_ILI9XXX(n, t))), \ - .dbi_config = { \ - .mode = DT_PROP_OR(INST_DT_ILI9XXX(n, t), mipi_mode, \ - MIPI_DBI_MODE_SPI_4WIRE), \ - .config = MIPI_DBI_SPI_CONFIG_DT( \ - INST_DT_ILI9XXX(n, t), \ - SPI_OP_MODE_MASTER | \ - SPI_WORD_SET(8), \ - 0), \ - }, \ - .pixel_format = DT_PROP(INST_DT_ILI9XXX(n, t), pixel_format), \ - .rotation = DT_PROP(INST_DT_ILI9XXX(n, t), rotation), \ - .x_resolution = ILI##t##_X_RES, \ - .y_resolution = ILI##t##_Y_RES, \ - .inversion = DT_PROP(INST_DT_ILI9XXX(n, t), display_inversion),\ - .regs = &ili9xxx_regs_##n, \ - .regs_init_fn = ili##t##_regs_init, \ - }; \ - \ - static struct ili9xxx_data ili9xxx_data_##n; \ - \ - DEVICE_DT_DEFINE(INST_DT_ILI9XXX(n, t), ili9xxx_init, \ - NULL, &ili9xxx_data_##n, \ - &ili9xxx_config_##n, POST_KERNEL, \ - CONFIG_DISPLAY_INIT_PRIORITY, &ili9xxx_api) +#define ILI9XXX_INIT(n, t) \ + ILI##t##_REGS_INIT(n); \ + \ + static const struct ili9xxx_config ili9xxx_config_##n = { \ + .quirks = &ili##t##_quirks, \ + .mipi_dev = DEVICE_DT_GET(DT_PARENT(INST_DT_ILI9XXX(n, t))), \ + .dbi_config = \ + { \ + .mode = DT_PROP_OR(INST_DT_ILI9XXX(n, t), mipi_mode, \ + MIPI_DBI_MODE_SPI_4WIRE), \ + .config = MIPI_DBI_SPI_CONFIG_DT( \ + INST_DT_ILI9XXX(n, t), \ + SPI_OP_MODE_MASTER | SPI_WORD_SET(8), 0), \ + }, \ + .pixel_format = DT_PROP(INST_DT_ILI9XXX(n, t), pixel_format), \ + .rotation = DT_PROP(INST_DT_ILI9XXX(n, t), rotation), \ + .x_resolution = ILI##t##_X_RES, \ + .y_resolution = ILI##t##_Y_RES, \ + .inversion = DT_PROP(INST_DT_ILI9XXX(n, t), display_inversion), \ + .regs = &ili9xxx_regs_##n, \ + .regs_init_fn = ili##t##_regs_init, \ + }; \ + \ + static struct ili9xxx_data ili9xxx_data_##n; \ + \ + DEVIC
You may want to run clang-format on this change: drivers/display/display_ili9xxx.c#L546
drivers/display/display_ili9xxx.c:546 -#define ILI9XXX_INIT(n, t) \ - ILI##t##_REGS_INIT(n); \ - \ - static const struct ili9xxx_config ili9xxx_config_##n = { \ - .quirks = &ili##t##_quirks, \ - .mipi_dev = DEVICE_DT_GET(DT_PARENT(INST_DT_ILI9XXX(n, t))), \ - .dbi_config = { \ - .mode = DT_PROP_OR(INST_DT_ILI9XXX(n, t), mipi_mode, \ - MIPI_DBI_MODE_SPI_4WIRE), \ - .config = MIPI_DBI_SPI_CONFIG_DT( \ - INST_DT_ILI9XXX(n, t), \ - SPI_OP_MODE_MASTER | \ - SPI_WORD_SET(8), \ - 0), \ - }, \ - .pixel_format = DT_PROP(INST_DT_ILI9XXX(n, t), pixel_format), \ - .rotation = DT_PROP(INST_DT_ILI9XXX(n, t), rotation), \ - .x_resolution = ILI##t##_X_RES, \ - .y_resolution = ILI##t##_Y_RES, \ - .inversion = DT_PROP(INST_DT_ILI9XXX(n, t), display_inversion),\ - .regs = &ili9xxx_regs_##n, \ - .regs_init_fn = ili##t##_regs_init, \ - }; \ - \ - static struct ili9xxx_data ili9xxx_data_##n; \ - \ - DEVICE_DT_DEFINE(INST_DT_ILI9XXX(n, t), ili9xxx_init, \ - NULL, &ili9xxx_data_##n, \ - &ili9xxx_config_##n, POST_KERNEL, \ - CONFIG_DISPLAY_INIT_PRIORITY, &ili9xxx_api) +#define ILI9XXX_INIT(n, t) \ + ILI##t##_REGS_INIT(n); \ + \ + static const struct ili9xxx_config ili9xxx_config_##n = { \ + .quirks = &ili##t##_quirks, \ + .mipi_dev = DEVICE_DT_GET(DT_PARENT(INST_DT_ILI9XXX(n, t))), \ + .dbi_config = \ + { \ + .mode = DT_PROP_OR(INST_DT_ILI9XXX(n, t), mipi_mode, \ + MIPI_DBI_MODE_SPI_4WIRE), \ + .config = MIPI_DBI_SPI_CONFIG_DT( \ + INST_DT_ILI9XXX(n, t), \ + SPI_OP_MODE_MASTER | SPI_WORD_SET(8), 0), \ + }, \ + .pixel_format = DT_PROP(INST_DT_ILI9XXX(n, t), pixel_format), \ + .rotation = DT_PROP(INST_DT_ILI9XXX(n, t), rotation), \ + .x_resolution = ILI##t##_X_RES, \ + .y_resolution = ILI##t##_Y_RES, \ + .inversion = DT_PROP(INST_DT_ILI9XXX(n, t), display_inversion), \ + .regs = &ili9xxx_regs_##n, \ + .regs_init_fn = ili##t##_regs_init, \ + }; \ + \ + static struct ili9xxx_data ili9xxx_data_##n; \ + \ + DEVICE_DT_DEFINE(INST_DT_ILI9XXX(n, t), ili9xxx_init, NULL, &ili9xxx_data_##n, \ + &ili9xxx_config_##n

Artifacts

Produced during runtime
Name Size
compliance.xml
1.49 KB