Skip to content

Bluetooth: Channel Sounding: Add several channel sounding HCI commands #150261

Bluetooth: Channel Sounding: Add several channel sounding HCI commands

Bluetooth: Channel Sounding: Add several channel sounding HCI commands #150261

Triggered via pull request September 19, 2024 10:38
Status Success
Total duration 2m 44s
Artifacts 1

compliance.yml

on: pull_request
Run compliance checks on patch series (PR)
2m 36s
Run compliance checks on patch series (PR)
Fit to window
Zoom out
Zoom in

Annotations

1 error, 1 warning, and 10 notices
Run compliance checks on patch series (PR)
Process completed with exit code 1.
Run compliance checks on patch series (PR): ClangFormat.txt#L1
See https://docs.zephyrproject.org/latest/contribute/guidelines.html#clang-format for more details. You may want to run clang-format on this change: -#define BT_LE_FEAT_BIT_CHANNEL_SOUNDING 46 -#define BT_LE_FEAT_BIT_CHANNEL_SOUNDING_HOST 47 +#define BT_LE_FEAT_BIT_CHANNEL_SOUNDING 46 +#define BT_LE_FEAT_BIT_CHANNEL_SOUNDING_HOST 47 File:include/zephyr/bluetooth/hci_types.h Line:206 You may want to run clang-format on this change: -#define BT_FEAT_LE_CHANNEL_SOUNDING(feat) BT_LE_FEAT_TEST(feat, \ - BT_LE_FEAT_BIT_CHANNEL_SOUNDING) -#define BT_FEAT_LE_CHANNEL_SOUNDING_HOST(feat) BT_LE_FEAT_TEST(feat, \ - BT_LE_FEAT_BIT_CHANNEL_SOUNDING_HOST) +#define BT_FEAT_LE_CHANNEL_SOUNDING(feat) BT_LE_FEAT_TEST(feat, BT_LE_FEAT_BIT_CHANNEL_SOUNDING) +#define BT_FEAT_LE_CHANNEL_SOUNDING_HOST(feat) \ + BT_LE_FEAT_TEST(feat, BT_LE_FEAT_BIT_CHANNEL_SOUNDING_HOST) File:include/zephyr/bluetooth/hci_types.h Line:278 You may want to run clang-format on this change: - #define BT_HCI_OP_LE_CS_TEST BT_OP(BT_OGF_LE, 0x0095) /* 0x2095 */ #define BT_HCI_OP_LE_CS_MAIN_MODE_1 0x1 #define BT_HCI_OP_LE_CS_MAIN_MODE_2 0x2 #define BT_HCI_OP_LE_CS_MAIN_MODE_3 0x3 -#define BT_HCI_OP_LE_CS_SUB_MODE_1 0x1 -#define BT_HCI_OP_LE_CS_SUB_MODE_2 0x2 -#define BT_HCI_OP_LE_CS_SUB_MODE_3 0x3 +#define BT_HCI_OP_LE_CS_SUB_MODE_1 0x1 +#define BT_HCI_OP_LE_CS_SUB_MODE_2 0x2 +#define BT_HCI_OP_LE_CS_SUB_MODE_3 0x3 File:include/zephyr/bluetooth/hci_types.h Line:2449 You may want to run clang-format on this change: -#define BT_HCI_OP_LE_CS_TEST_INITIATOR_SNR_18 0x0 -#define BT_HCI_OP_LE_CS_TEST_INITIATOR_SNR_21 0x1 -#define BT_HCI_OP_LE_CS_TEST_INITIATOR_SNR_24 0x2 -#define BT_HCI_OP_LE_CS_TEST_INITIATOR_SNR_27 0x3 -#define BT_HCI_OP_LE_CS_TEST_INITIATOR_SNR_30 0x4 +#define BT_HCI_OP_LE_CS_TEST_INITIATOR_SNR_18 0x0 +#define BT_HCI_OP_LE_CS_TEST_INITIATOR_SNR_21 0x1 +#define BT_HCI_OP_LE_CS_TEST_INITIATOR_SNR_24 0x2 +#define BT_HCI_OP_LE_CS_TEST_INITIATOR_SNR_27 0x3 +#define BT_HCI_OP_LE_CS_TEST_INITIATOR_SNR_30 0x4 #define BT_HCI_OP_LE_CS_TEST_INITIATOR_SNR_NOT_USED 0xFF -#define BT_HCI_OP_LE_CS_TEST_REFLECTOR_SNR_18 0x0 -#define BT_HCI_OP_LE_CS_TEST_REFLECTOR_SNR_21 0x1 -#define BT_HCI_OP_LE_CS_TEST_REFLECTOR_SNR_24 0x2 -#define BT_HCI_OP_LE_CS_TEST_REFLECTOR_SNR_27 0x3 -#define BT_HCI_OP_LE_CS_TEST_REFLECTOR_SNR_30 0x4 +#define BT_HCI_OP_LE_CS_TEST_REFLECTOR_SNR_18 0x0 +#define BT_HCI_OP_LE_CS_TEST_REFLECTOR_SNR_21 0x1 +#define BT_HCI_OP_LE_CS_TEST_REFLECTOR_SNR_24 0x2 +#define BT_HCI_OP_LE_CS_TEST_REFLECTOR_SNR_27 0x3 +#define BT_HCI_OP_LE_CS_TEST_REFLECTOR_SNR_30 0x4 #define BT_HCI_OP_LE_CS_TEST_REFLECTOR_SNR_NOT_USED 0xFF -#define BT_HCI_OP_LE_CS_TEST_OVERRIDE_CONFIG_0_MASK BIT(0) -#define BT_HCI_OP_LE_CS_TEST_OVERRIDE_CONFIG_2_MASK BIT(2) -#define BT_HCI_OP_LE_CS_TEST_OVERRIDE_CONFIG_3_MASK BIT(3) -#define BT_HCI_OP_LE_CS_TEST_OVERRIDE_CONFIG_4_MASK BIT(4) -#define BT_HCI_OP_LE_CS_TEST_OVERRIDE_CONFIG_5_MASK BIT(5) -#define BT_HCI_OP_LE_CS_TEST_OVERRIDE_CONFIG_6_MASK BIT(6) -#define BT_HCI_OP_LE_CS_TEST_OVERRIDE_CONFIG_7_MASK BIT(7) -#define BT_HCI_OP_LE_CS_TEST_OVERRIDE_CONFIG_8_MASK BIT(8) +#define BT_HCI_OP_LE_CS_TEST_OVERRIDE_CONFIG_0_MASK BIT(0) +#define BT_HCI_OP_LE_CS_TEST_OVERRIDE_CONFIG_2_MASK BIT(2) +#define BT_HCI_OP_LE_CS_TEST_OVERRIDE_CONFIG_3_MASK BIT(3) +#define BT_HCI_OP_LE_CS_TEST_OVERRIDE_CONFIG_4_MASK BIT(4) +#define BT_HCI_OP_LE_CS_TEST_OVERRIDE_CONFIG_5_MASK BIT(5) +#define BT_HCI_OP_LE_CS_TEST_OVERRIDE_CONFIG_6_MASK BIT(6) +#define BT_HCI_OP_LE_CS_TEST_OVERRIDE_CONFIG_7_MASK BIT(7) +#define BT_HCI_OP_LE_CS_TEST_OVERRIDE_CONFIG_8_MASK BIT(8) File:include/zephyr/bluetooth/hci_types.h Line:2500 You may want to run clang-format on this change: -#define BT_HCI_OP_LE_CS_TEST_TONE_EXT_NONE 0x0 -#define BT_HCI_OP_LE_CS_TEST_TONE_EXT_INIT 0x1 -#define BT_HCI_OP_LE_CS_TEST_TONE_EXT_REFL 0x2 -#define BT_HCI_OP_LE_CS_TEST_TONE_EXT_BOTH 0x3 +#define BT_HCI
You may want to run clang-format on this change: include/zephyr/bluetooth/hci_types.h#L206
include/zephyr/bluetooth/hci_types.h:206 -#define BT_LE_FEAT_BIT_CHANNEL_SOUNDING 46 -#define BT_LE_FEAT_BIT_CHANNEL_SOUNDING_HOST 47 +#define BT_LE_FEAT_BIT_CHANNEL_SOUNDING 46 +#define BT_LE_FEAT_BIT_CHANNEL_SOUNDING_HOST 47
You may want to run clang-format on this change: include/zephyr/bluetooth/hci_types.h#L278
include/zephyr/bluetooth/hci_types.h:278 -#define BT_FEAT_LE_CHANNEL_SOUNDING(feat) BT_LE_FEAT_TEST(feat, \ - BT_LE_FEAT_BIT_CHANNEL_SOUNDING) -#define BT_FEAT_LE_CHANNEL_SOUNDING_HOST(feat) BT_LE_FEAT_TEST(feat, \ - BT_LE_FEAT_BIT_CHANNEL_SOUNDING_HOST) +#define BT_FEAT_LE_CHANNEL_SOUNDING(feat) BT_LE_FEAT_TEST(feat, BT_LE_FEAT_BIT_CHANNEL_SOUNDING) +#define BT_FEAT_LE_CHANNEL_SOUNDING_HOST(feat) \ + BT_LE_FEAT_TEST(feat, BT_LE_FEAT_BIT_CHANNEL_SOUNDING_HOST)
You may want to run clang-format on this change: include/zephyr/bluetooth/hci_types.h#L2449
include/zephyr/bluetooth/hci_types.h:2449 - #define BT_HCI_OP_LE_CS_TEST BT_OP(BT_OGF_LE, 0x0095) /* 0x2095 */ #define BT_HCI_OP_LE_CS_MAIN_MODE_1 0x1 #define BT_HCI_OP_LE_CS_MAIN_MODE_2 0x2 #define BT_HCI_OP_LE_CS_MAIN_MODE_3 0x3 -#define BT_HCI_OP_LE_CS_SUB_MODE_1 0x1 -#define BT_HCI_OP_LE_CS_SUB_MODE_2 0x2 -#define BT_HCI_OP_LE_CS_SUB_MODE_3 0x3 +#define BT_HCI_OP_LE_CS_SUB_MODE_1 0x1 +#define BT_HCI_OP_LE_CS_SUB_MODE_2 0x2 +#define BT_HCI_OP_LE_CS_SUB_MODE_3 0x3
You may want to run clang-format on this change: include/zephyr/bluetooth/hci_types.h#L2500
include/zephyr/bluetooth/hci_types.h:2500 -#define BT_HCI_OP_LE_CS_TEST_INITIATOR_SNR_18 0x0 -#define BT_HCI_OP_LE_CS_TEST_INITIATOR_SNR_21 0x1 -#define BT_HCI_OP_LE_CS_TEST_INITIATOR_SNR_24 0x2 -#define BT_HCI_OP_LE_CS_TEST_INITIATOR_SNR_27 0x3 -#define BT_HCI_OP_LE_CS_TEST_INITIATOR_SNR_30 0x4 +#define BT_HCI_OP_LE_CS_TEST_INITIATOR_SNR_18 0x0 +#define BT_HCI_OP_LE_CS_TEST_INITIATOR_SNR_21 0x1 +#define BT_HCI_OP_LE_CS_TEST_INITIATOR_SNR_24 0x2 +#define BT_HCI_OP_LE_CS_TEST_INITIATOR_SNR_27 0x3 +#define BT_HCI_OP_LE_CS_TEST_INITIATOR_SNR_30 0x4 #define BT_HCI_OP_LE_CS_TEST_INITIATOR_SNR_NOT_USED 0xFF -#define BT_HCI_OP_LE_CS_TEST_REFLECTOR_SNR_18 0x0 -#define BT_HCI_OP_LE_CS_TEST_REFLECTOR_SNR_21 0x1 -#define BT_HCI_OP_LE_CS_TEST_REFLECTOR_SNR_24 0x2 -#define BT_HCI_OP_LE_CS_TEST_REFLECTOR_SNR_27 0x3 -#define BT_HCI_OP_LE_CS_TEST_REFLECTOR_SNR_30 0x4 +#define BT_HCI_OP_LE_CS_TEST_REFLECTOR_SNR_18 0x0 +#define BT_HCI_OP_LE_CS_TEST_REFLECTOR_SNR_21 0x1 +#define BT_HCI_OP_LE_CS_TEST_REFLECTOR_SNR_24 0x2 +#define BT_HCI_OP_LE_CS_TEST_REFLECTOR_SNR_27 0x3 +#define BT_HCI_OP_LE_CS_TEST_REFLECTOR_SNR_30 0x4 #define BT_HCI_OP_LE_CS_TEST_REFLECTOR_SNR_NOT_USED 0xFF -#define BT_HCI_OP_LE_CS_TEST_OVERRIDE_CONFIG_0_MASK BIT(0) -#define BT_HCI_OP_LE_CS_TEST_OVERRIDE_CONFIG_2_MASK BIT(2) -#define BT_HCI_OP_LE_CS_TEST_OVERRIDE_CONFIG_3_MASK BIT(3) -#define BT_HCI_OP_LE_CS_TEST_OVERRIDE_CONFIG_4_MASK BIT(4) -#define BT_HCI_OP_LE_CS_TEST_OVERRIDE_CONFIG_5_MASK BIT(5) -#define BT_HCI_OP_LE_CS_TEST_OVERRIDE_CONFIG_6_MASK BIT(6) -#define BT_HCI_OP_LE_CS_TEST_OVERRIDE_CONFIG_7_MASK BIT(7) -#define BT_HCI_OP_LE_CS_TEST_OVERRIDE_CONFIG_8_MASK BIT(8) +#define BT_HCI_OP_LE_CS_TEST_OVERRIDE_CONFIG_0_MASK BIT(0) +#define BT_HCI_OP_LE_CS_TEST_OVERRIDE_CONFIG_2_MASK BIT(2) +#define BT_HCI_OP_LE_CS_TEST_OVERRIDE_CONFIG_3_MASK BIT(3) +#define BT_HCI_OP_LE_CS_TEST_OVERRIDE_CONFIG_4_MASK BIT(4) +#define BT_HCI_OP_LE_CS_TEST_OVERRIDE_CONFIG_5_MASK BIT(5) +#define BT_HCI_OP_LE_CS_TEST_OVERRIDE_CONFIG_6_MASK BIT(6) +#define BT_HCI_OP_LE_CS_TEST_OVERRIDE_CONFIG_7_MASK BIT(7) +#define BT_HCI_OP_LE_CS_TEST_OVERRIDE_CONFIG_8_MASK BIT(8)
You may want to run clang-format on this change: include/zephyr/bluetooth/hci_types.h#L2538
include/zephyr/bluetooth/hci_types.h:2538 -#define BT_HCI_OP_LE_CS_TEST_TONE_EXT_NONE 0x0 -#define BT_HCI_OP_LE_CS_TEST_TONE_EXT_INIT 0x1 -#define BT_HCI_OP_LE_CS_TEST_TONE_EXT_REFL 0x2 -#define BT_HCI_OP_LE_CS_TEST_TONE_EXT_BOTH 0x3 +#define BT_HCI_OP_LE_CS_TEST_TONE_EXT_NONE 0x0 +#define BT_HCI_OP_LE_CS_TEST_TONE_EXT_INIT 0x1 +#define BT_HCI_OP_LE_CS_TEST_TONE_EXT_REFL 0x2 +#define BT_HCI_OP_LE_CS_TEST_TONE_EXT_BOTH 0x3 #define BT_HCI_OP_LE_CS_TEST_TONE_EXT_REPEAT 0x4 -#define BT_HCI_OP_LE_CS_TEST_AP_INDEX_00 0x0 -#define BT_HCI_OP_LE_CS_TEST_AP_INDEX_01 0x1 -#define BT_HCI_OP_LE_CS_TEST_AP_INDEX_02 0x2 -#define BT_HCI_OP_LE_CS_TEST_AP_INDEX_03 0x3 -#define BT_HCI_OP_LE_CS_TEST_AP_INDEX_04 0x4 -#define BT_HCI_OP_LE_CS_TEST_AP_INDEX_05 0x5 -#define BT_HCI_OP_LE_CS_TEST_AP_INDEX_06 0x6 -#define BT_HCI_OP_LE_CS_TEST_AP_INDEX_07 0x7 -#define BT_HCI_OP_LE_CS_TEST_AP_INDEX_08 0x8 -#define BT_HCI_OP_LE_CS_TEST_AP_INDEX_09 0x9 -#define BT_HCI_OP_LE_CS_TEST_AP_INDEX_10 0xA -#define BT_HCI_OP_LE_CS_TEST_AP_INDEX_11 0xB -#define BT_HCI_OP_LE_CS_TEST_AP_INDEX_12 0xC -#define BT_HCI_OP_LE_CS_TEST_AP_INDEX_13 0xD -#define BT_HCI_OP_LE_CS_TEST_AP_INDEX_14 0xE -#define BT_HCI_OP_LE_CS_TEST_AP_INDEX_15 0xF -#define BT_HCI_OP_LE_CS_TEST_AP_INDEX_16 0x10 -#define BT_HCI_OP_LE_CS_TEST_AP_INDEX_17 0x11 -#define BT_HCI_OP_LE_CS_TEST_AP_INDEX_18 0x12 -#define BT_HCI_OP_LE_CS_TEST_AP_INDEX_19 0x13 -#define BT_HCI_OP_LE_CS_TEST_AP_INDEX_20 0x14 -#define BT_HCI_OP_LE_CS_TEST_AP_INDEX_21 0x15 -#define BT_HCI_OP_LE_CS_TEST_AP_INDEX_22 0x16 -#define BT_HCI_OP_LE_CS_TEST_AP_INDEX_23 0x17 +#define BT_HCI_OP_LE_CS_TEST_AP_INDEX_00 0x0 +#define BT_HCI_OP_LE_CS_TEST_AP_INDEX_01 0x1 +#define BT_HCI_OP_LE_CS_TEST_AP_INDEX_02 0x2 +#define BT_HCI_OP_LE_CS_TEST_AP_INDEX_03 0x3 +#define BT_HCI_OP_LE_CS_TEST_AP_INDEX_04 0x4 +#define BT_HCI_OP_LE_CS_TEST_AP_INDEX_05 0x5 +#define BT_HCI_OP_LE_CS_TEST_AP_INDEX_06 0x6 +#define BT_HCI_OP_LE_CS_TEST_AP_INDEX_07 0x7 +#define BT_HCI_OP_LE_CS_TEST_AP_INDEX_08 0x8 +#define BT_HCI_OP_LE_CS_TEST_AP_INDEX_09 0x9 +#define BT_HCI_OP_LE_CS_TEST_AP_INDEX_10 0xA +#define BT_HCI_OP_LE_CS_TEST_AP_INDEX_11 0xB +#define BT_HCI_OP_LE_CS_TEST_AP_INDEX_12 0xC +#define BT_HCI_OP_LE_CS_TEST_AP_INDEX_13 0xD +#define BT_HCI_OP_LE_CS_TEST_AP_INDEX_14 0xE +#define BT_HCI_OP_LE_CS_TEST_AP_INDEX_15 0xF +#define BT_HCI_OP_LE_CS_TEST_AP_INDEX_16 0x10 +#define BT_HCI_OP_LE_CS_TEST_AP_INDEX_17 0x11 +#define BT_HCI_OP_LE_CS_TEST_AP_INDEX_18 0x12 +#define BT_HCI_OP_LE_CS_TEST_AP_INDEX_19 0x13 +#define BT_HCI_OP_LE_CS_TEST_AP_INDEX_20 0x14 +#define BT_HCI_OP_LE_CS_TEST_AP_INDEX_21 0x15 +#define BT_HCI_OP_LE_CS_TEST_AP_INDEX_22 0x16 +#define BT_HCI_OP_LE_CS_TEST_AP_INDEX_23 0x17
You may want to run clang-format on this change: include/zephyr/bluetooth/hci_types.h#L3336
include/zephyr/bluetooth/hci_types.h:3336 -#define BT_HCI_LE_CS_NADM_RANDOM_CAPABILITY_PHASE_BASED_MASK BIT(0) - -#define BT_HCI_LE_CS_SYNC_PHYS_2M_MASK BIT(1) +#define BT_HCI_LE_CS_NADM_RANDOM_CAPABILITY_PHASE_BASED_MASK BIT(0) + +#define BT_HCI_LE_CS_SYNC_PHYS_2M_MASK BIT(1) #define BT_HCI_LE_CS_SYNC_PHYS_2M_2BT_MASK BIT(2) -#define BT_HCI_LE_CS_SUBFEATURE_NO_TX_FAE_MASK BIT(1) -#define BT_HCI_LE_CS_SUBFEATURE_CHSEL_ALG_3C_MASK BIT(2) +#define BT_HCI_LE_CS_SUBFEATURE_NO_TX_FAE_MASK BIT(1) +#define BT_HCI_LE_CS_SUBFEATURE_CHSEL_ALG_3C_MASK BIT(2)
You may want to run clang-format on this change: subsys/bluetooth/host/conn_internal.h#L500
subsys/bluetooth/host/conn_internal.h:500 -void notify_remote_cs_capabilities(struct bt_conn *conn, - struct bt_conn_le_cs_capabilities params); - -void notify_remote_cs_fae_table(struct bt_conn *conn, - struct bt_conn_le_cs_fae_table params); +void notify_remote_cs_capabilities(struct bt_conn *conn, struct bt_conn_le_cs_capabilities params); + +void notify_remote_cs_fae_table(struct bt_conn *conn, struct bt_conn_le_cs_fae_table params);
You may want to run clang-format on this change: subsys/bluetooth/host/hci_core.c#L2697
subsys/bluetooth/host/hci_core.c:2697 - EVENT_HANDLER(BT_HCI_EVT_LE_CONN_UPDATE_COMPLETE, - le_conn_update_complete, + EVENT_HANDLER(BT_HCI_EVT_LE_CONN_UPDATE_COMPLETE, le_conn_update_complete, sizeof(struct bt_hci_evt_le_conn_update_complete)), - EVENT_HANDLER(BT_HCI_EVT_LE_REMOTE_FEAT_COMPLETE, - le_remote_feat_complete, + EVENT_HANDLER(BT_HCI_EVT_LE_REMOTE_FEAT_COMPLETE, le_remote_feat_complete,
You may want to run clang-format on this change: subsys/bluetooth/host/hci_core.c#L2707
subsys/bluetooth/host/hci_core.c:2707 - EVENT_HANDLER(BT_HCI_EVT_LE_PHY_UPDATE_COMPLETE, - le_phy_update_complete, + EVENT_HANDLER(BT_HCI_EVT_LE_PHY_UPDATE_COMPLETE, le_phy_update_complete,
You may want to run clang-format on this change: subsys/bluetooth/host/hci_core.c#L2720
subsys/bluetooth/host/hci_core.c:2720 - EVENT_HANDLER(BT_HCI_EVT_LE_P256_PUBLIC_KEY_COMPLETE, - bt_hci_evt_le_pkey_complete, + EVENT_HANDLER(BT_HCI_EVT_LE_P256_PUBLIC_KEY_COMPLETE, bt_hci_evt_le_pkey_complete, sizeof(struct bt_hci_evt_le_p256_public_key_complete)), - EVENT_HANDLER(BT_HCI_EVT_LE_GENERATE_DHKEY_COMPLETE, - bt_hci_evt_le_dhkey_complete, + EVENT_HANDLER(BT_HCI_EVT_LE_GENERATE_DHKEY_COMPLETE, bt_hci_evt_le_dhkey_complete,

Artifacts

Produced during runtime
Name Size
compliance.xml
2.94 KB