Supporting Pimoroni Pico Plus2 #151851
soburicompliance.yml
on: pull_request
Run compliance checks on patch series (PR)
3m 0s
Annotations
18 errors, 6 warnings, and 10 notices
|
BoardYml:
boards/pimoroni/pico_plus2/board.yml#L3
/home/runner/work/zephyr/zephyr/boards/pimoroni/pico_plus2/board.yml:3 invalid vendor: pimoroni
|
|
C99_COMMENTS:
drivers/gpio/gpio_pca953x.c#L310
drivers/gpio/gpio_pca953x.c:310 do not use C99 // comments
|
|
C99_COMMENTS:
drivers/gpio/gpio_pca953x.c#L311
drivers/gpio/gpio_pca953x.c:311 do not use C99 // comments
|
|
C99_COMMENTS:
drivers/gpio/gpio_sx1509b.c#L441
drivers/gpio/gpio_sx1509b.c:441 do not use C99 // comments
|
|
SphinxLint:
boards/pimoroni/pico_plus2/doc/index.rst#L140
boards/pimoroni/pico_plus2/doc/index.rst:140 default role used (hint: for inline literals, use double backticks) (default-role)
|
|
SphinxLint:
boards/pimoroni/pico_plus2/doc/index.rst#L144
boards/pimoroni/pico_plus2/doc/index.rst:144 default role used (hint: for inline literals, use double backticks) (default-role)
|
|
SphinxLint:
boards/pimoroni/pico_plus2/doc/index.rst#L190
boards/pimoroni/pico_plus2/doc/index.rst:190 default role used (hint: for inline literals, use double backticks) (default-role)
|
|
SphinxLint:
boards/pimoroni/pico_plus2/doc/index.rst#L211
boards/pimoroni/pico_plus2/doc/index.rst:211 default role used (hint: for inline literals, use double backticks) (default-role)
|
|
SphinxLint:
boards/pimoroni/pico_plus2/doc/index.rst#L212
boards/pimoroni/pico_plus2/doc/index.rst:212 default role used (hint: for inline literals, use double backticks) (default-role)
|
|
SphinxLint:
boards/pimoroni/pico_plus2/doc/index.rst#L218
boards/pimoroni/pico_plus2/doc/index.rst:218 default role used (hint: for inline literals, use double backticks) (default-role)
|
|
Run compliance checks on patch series (PR):
Identity.txt#L1
See https://docs.zephyrproject.org/latest/contribute/guidelines.html#commit-guidelines for more details
40f7d5e7edc702e0fc4b1a3c138fc998ff712fd2: author email (TOKITA Hiroshi <tokita.hiroshi@gmail.com>) needs to match one of the signed-off-by entries.
830060096e9ebbdbb39df3616ce20169460d7a17: author email (TOKITA Hiroshi <tokita.hiroshi@gmail.com>) needs to match one of the signed-off-by entries.
521fee78a57f081971e9bab5d27f2b72b5b572a5: author email (TOKITA Hiroshi <tokita.hiroshi@gmail.com>) needs to match one of the signed-off-by entries.
741a1d1e0a036f0baaf275a3f462e0bf2b8fedc9: author email (TOKITA Hiroshi <tokita.hiroshi@gmail.com>) needs to match one of the signed-off-by entries.
f5e4247057669bef4b3045c7dd24b6f46ad742f8: author email (TOKITA Hiroshi <tokita.hiroshi@gmail.com>) needs to match one of the signed-off-by entries.
deef1ae7bf1d3736c8ca5df2371ca43c5bf675ae: author email (TOKITA Hiroshi <tokita.hiroshi@gmail.com>) needs to match one of the signed-off-by entries.
558e50910686d75b9c88f6719515eb63f3d148ba: author email (TOKITA Hiroshi <tokita.hiroshi@fujitsu.com>) needs to match one of the signed-off-by entries.
bd105109b737f580231c44bffbc5a4ab3ad203b5: author email (TOKITA Hiroshi <tokita.hiroshi@jp.fujitsu.com>) needs to match one of the signed-off-by entries.
68c06a9f23ab62af907026a1389864c2ad812c0c: author email (TOKITA Hiroshi <tokita.hiroshi@gmail.com>) needs to match one of the signed-off-by entries.
|
|
Run compliance checks on patch series (PR):
Checkpatch.txt#L1
See https://docs.zephyrproject.org/latest/contribute/guidelines.html#coding-style for more details.
LONG_LINE: line length of 113 exceeds 100 columns
File:drivers/gpio/gpio_mcp23xxx.c
Line:227
C99_COMMENTS: do not use C99 // comments
File:drivers/gpio/gpio_pca953x.c
Line:310
C99_COMMENTS: do not use C99 // comments
File:drivers/gpio/gpio_pca953x.c
Line:311
C99_COMMENTS: do not use C99 // comments
File:drivers/gpio/gpio_sx1509b.c
Line:441
LONG_LINE: line length of 101 exceeds 100 columns
File:drivers/rtc/rtc_pcf8563.c
Line:445
LONG_LINE: line length of 103 exceeds 100 columns
File:drivers/sensor/apds9253/apds9253.c
Line:185
LONG_LINE: line length of 105 exceeds 100 columns
File:drivers/sensor/st/ism330dhcx/ism330dhcx_trigger.c
Line:284
TYPO_SPELLING: 'guage' may be misspelled - perhaps 'gauge'?
File:tests/drivers/build_all/sensor/i2c.dtsi
Line:1117
|
|
Run compliance checks on patch series (PR):
SphinxLint.txt#L1
Check Sphinx/reStructuredText files with sphinx-lint.
SphinxLint:default role used (hint: for inline literals, use double backticks) (default-role)
File:boards/pimoroni/pico_plus2/doc/index.rst
Line:140
SphinxLint:default role used (hint: for inline literals, use double backticks) (default-role)
File:boards/pimoroni/pico_plus2/doc/index.rst
Line:144
SphinxLint:default role used (hint: for inline literals, use double backticks) (default-role)
File:boards/pimoroni/pico_plus2/doc/index.rst
Line:190
SphinxLint:default role used (hint: for inline literals, use double backticks) (default-role)
File:boards/pimoroni/pico_plus2/doc/index.rst
Line:211
SphinxLint:default role used (hint: for inline literals, use double backticks) (default-role)
File:boards/pimoroni/pico_plus2/doc/index.rst
Line:212
SphinxLint:default role used (hint: for inline literals, use double backticks) (default-role)
File:boards/pimoroni/pico_plus2/doc/index.rst
Line:218
SphinxLint:default role used (hint: for inline literals, use double backticks) (default-role)
File:boards/pimoroni/pico_plus2/doc/index.rst
Line:219
SphinxLint:default role used (hint: for inline literals, use double backticks) (default-role)
File:boards/pimoroni/pico_plus2/doc/index.rst
Line:220
SphinxLint:default role used (hint: for inline literals, use double backticks) (default-role)
File:boards/pimoroni/pico_plus2/doc/index.rst
Line:224
SphinxLint:default role used (hint: for inline literals, use double backticks) (default-role)
File:boards/pimoroni/pico_plus2/doc/index.rst
Line:226
SphinxLint:default role used (hint: for inline literals, use double backticks) (default-role)
File:boards/pimoroni/pico_plus2/doc/index.rst
Line:241
SphinxLint:default role used (hint: for inline literals, use double backticks) (default-role)
File:boards/pimoroni/pico_plus2/doc/index.rst
Line:273
|
|
Run compliance checks on patch series (PR):
Kconfig.txt#L1
See https://docs.zephyrproject.org/latest/build/kconfig/tips.html for more details.
Undefined Kconfig symbols:
warning: undefined symbol SOC_SEREIS_RP2350:
- Referenced at drivers/gpio/Kconfig.rpi_pico:4:
config GPIO_RPI_PICO
bool "Raspberry Pi Pico GPIO driver"
default y
select PICOSDK_USE_GPIO
select GPIO_64BIT_PORT if SOC_SEREIS_RP2350
depends on DT_HAS_RASPBERRYPI_PICO_GPIO_ENABLED && GPIO
|
|
Run compliance checks on patch series (PR):
KconfigBasicNoModules.txt#L1
See https://docs.zephyrproject.org/latest/build/kconfig/tips.html for more details.
Undefined Kconfig symbols:
warning: undefined symbol SOC_SEREIS_RP2350:
- Referenced at drivers/gpio/Kconfig.rpi_pico:4:
config GPIO_RPI_PICO
bool "Raspberry Pi Pico GPIO driver"
default y
select PICOSDK_USE_GPIO
select GPIO_64BIT_PORT if SOC_SEREIS_RP2350
depends on DT_HAS_RASPBERRYPI_PICO_GPIO_ENABLED && GPIO
|
|
Run compliance checks on patch series (PR):
Gitlint.txt#L1
See https://docs.zephyrproject.org/latest/contribute/guidelines.html#commit-guidelines for more details
Commit 40f7d5e7ed:
1: T8 Title is too short (3<5): "tmp"
1: UC2 Commit message does not contain a 'Signed-off-by:' line
1: UC3 Commit title does not follow [subsystem]: [subject] (and should not start with literal subsys or treewide): "tmp"
1: UC6 Commit message body is empty, should at least have 1 line(s).
3: B6 Body message is missing
Commit 830060096e:
1: UC2 Commit message does not contain a 'Signed-off-by:' line
Commit 521fee78a5:
1: UC2 Commit message does not contain a 'Signed-off-by:' line
Commit 741a1d1e0a:
1: UC2 Commit message does not contain a 'Signed-off-by:' line
Commit f5e4247057:
1: UC2 Commit message does not contain a 'Signed-off-by:' line
1: UC3 Commit title does not follow [subsystem]: [subject] (and should not start with literal subsys or treewide): "64bit"
1: UC6 Commit message body is empty, should at least have 1 line(s).
3: B6 Body message is missing
Commit deef1ae7bf:
1: UC2 Commit message does not contain a 'Signed-off-by:' line
1: UC3 Commit title does not follow [subsystem]: [subject] (and should not start with literal subsys or treewide): "gpio_rpi_pico"
1: UC6 Commit message body is empty, should at least have 1 line(s).
3: B6 Body message is missing
Commit 558e509106:
1: UC2 Commit message does not contain a 'Signed-off-by:' line
1: UC3 Commit title does not follow [subsystem]: [subject] (and should not start with literal subsys or treewide): "gpio64"
1: UC6 Commit message body is empty, should at least have 1 line(s).
3: B6 Body message is missing
Commit bd105109b7:
1: UC2 Commit message does not contain a 'Signed-off-by:' line
1: UC3 Commit title does not follow [subsystem]: [subject] (and should not start with literal subsys or treewide): "pimoroni pico_plus2"
1: UC6 Commit message body is empty, should at least have 1 line(s).
3: B6 Body message is missing
Commit 68c06a9f23:
1: UC2 Commit message does not contain a 'Signed-off-by:' line
1: UC3 Commit title does not follow [subsystem]: [subject] (and should not start with literal subsys or treewide): "rp2350b"
1: UC6 Commit message body is empty, should at least have 1 line(s).
3: B6 Body message is missing
|
|
Run compliance checks on patch series (PR):
BoardYml.txt#L1
Check the board.yml file format
BoardYml:invalid vendor: pimoroni
File:/home/runner/work/zephyr/zephyr/boards/pimoroni/pico_plus2/board.yml
Line:3
|
|
Run compliance checks on patch series (PR)
Process completed with exit code 1.
|
|
You may want to run clang-format on this change:
boards/nordic/nrf9160dk/board.c#L99
boards/nordic/nrf9160dk/board.c:99
-static void chip_reset(const struct device *gpio,
- struct gpio_callback *cb, gpio_port_pins_t pins)
+static void chip_reset(const struct device *gpio, struct gpio_callback *cb, gpio_port_pins_t pins)
|
|
You may want to run clang-format on this change:
drivers/adc/adc_ads1x1x.c#L684
drivers/adc/adc_ads1x1x.c:684
-static void ads1x1x_conv_ready_cb(const struct device *gpio_dev,
- struct gpio_callback *cb,
- gpio_port_pins_t pins)
+static void ads1x1x_conv_ready_cb(const struct device *gpio_dev, struct gpio_callback *cb,
+ gpio_port_pins_t pins)
|
|
You may want to run clang-format on this change:
drivers/adc/adc_ads1x1x.c#L730
drivers/adc/adc_ads1x1x.c:730
- gpio_init_callback(&data->gpio_cb, ads1x1x_conv_ready_cb,
- GPIO_BIT(config->alert_rdy.pin));
+ gpio_init_callback(&data->gpio_cb, ads1x1x_conv_ready_cb, GPIO_BIT(config->alert_rdy.pin));
|
|
You may want to run clang-format on this change:
drivers/adc/adc_lmp90xxx.c#L712
drivers/adc/adc_lmp90xxx.c:712
-static void lmp90xxx_drdyb_callback(const struct device *port,
- struct gpio_callback *cb, gpio_port_pins_t pins)
+static void lmp90xxx_drdyb_callback(const struct device *port, struct gpio_callback *cb,
+ gpio_port_pins_t pins)
|
|
You may want to run clang-format on this change:
drivers/bluetooth/hci/hci_spi_st.c#L175
drivers/bluetooth/hci/hci_spi_st.c:175
-static void bt_spi_isr(const struct device *unused1,
- struct gpio_callback *unused2,
+static void bt_spi_isr(const struct device *unused1, struct gpio_callback *unused2,
|
|
You may want to run clang-format on this change:
drivers/bluetooth/hci/spi.c#L124
drivers/bluetooth/hci/spi.c:124
-static void bt_spi_isr(const struct device *unused1,
- struct gpio_callback *unused2,
+static void bt_spi_isr(const struct device *unused1, struct gpio_callback *unused2,
|
|
You may want to run clang-format on this change:
drivers/can/can_mcp2515.c#L873
drivers/can/can_mcp2515.c:873
-static void mcp2515_int_gpio_callback(const struct device *dev,
- struct gpio_callback *cb, gpio_port_pins_t pins)
+static void mcp2515_int_gpio_callback(const struct device *dev, struct gpio_callback *cb,
+ gpio_port_pins_t pins)
|
|
You may want to run clang-format on this change:
drivers/clock_control/clock_control_rpi_pico.c#L120
drivers/clock_control/clock_control_rpi_pico.c:120
-#define AUXSRC_lposc LPOSC_CLKSRC
-#define AUXSRC_clk_hstx CLK_HSTX
-#define AUXSRC_otp_clk2fc OTP_CLK2FC
+#define AUXSRC_lposc LPOSC_CLKSRC
+#define AUXSRC_clk_hstx CLK_HSTX
+#define AUXSRC_otp_clk2fc OTP_CLK2FC
|
|
You may want to run clang-format on this change:
drivers/clock_control/clock_control_rpi_pico.c#L131
drivers/clock_control/clock_control_rpi_pico.c:131
-#define AUXSTEM_clk_peri CLOCKS_CLK_PERI_CTRL_AUXSRC_VALUE_
+#define AUXSTEM_clk_peri CLOCKS_CLK_PERI_CTRL_AUXSRC_VALUE_
|
|
You may want to run clang-format on this change:
drivers/clock_control/clock_control_rpi_pico.c#L325
drivers/clock_control/clock_control_rpi_pico.c:325
- rpi_pico_clkid_pll_sys,
- rpi_pico_clkid_gpin0,
- rpi_pico_clkid_gpin1,
- rpi_pico_clkid_pll_usb,
- rpi_pico_clkid_rosc_ph,
- rpi_pico_clkid_xosc,
- rpi_pico_clkid_clk_sys,
- rpi_pico_clkid_clk_usb,
- rpi_pico_clkid_clk_adc,
+ rpi_pico_clkid_pll_sys, rpi_pico_clkid_gpin0, rpi_pico_clkid_gpin1,
+ rpi_pico_clkid_pll_usb, rpi_pico_clkid_rosc_ph, rpi_pico_clkid_xosc,
+ rpi_pico_clkid_clk_sys, rpi_pico_clkid_clk_usb, rpi_pico_clkid_clk_adc,
|
|
LONG_LINE:
drivers/gpio/gpio_mcp23xxx.c#L227
drivers/gpio/gpio_mcp23xxx.c:227 line length of 113 exceeds 100 columns
|
|
LONG_LINE:
drivers/rtc/rtc_pcf8563.c#L445
drivers/rtc/rtc_pcf8563.c:445 line length of 101 exceeds 100 columns
|
|
LONG_LINE:
drivers/sensor/apds9253/apds9253.c#L185
drivers/sensor/apds9253/apds9253.c:185 line length of 103 exceeds 100 columns
|
|
LONG_LINE:
drivers/sensor/st/ism330dhcx/ism330dhcx_trigger.c#L284
drivers/sensor/st/ism330dhcx/ism330dhcx_trigger.c:284 line length of 105 exceeds 100 columns
|
|
TYPO_SPELLING:
tests/drivers/build_all/sensor/i2c.dtsi#L1117
tests/drivers/build_all/sensor/i2c.dtsi:1117 'guage' may be misspelled - perhaps 'gauge'?
|
|
Run compliance checks on patch series (PR):
ClangFormat.txt#L1
See https://docs.zephyrproject.org/latest/contribute/guidelines.html#clang-format for more details.
You may want to run clang-format on this change:
-static void chip_reset(const struct device *gpio,
- struct gpio_callback *cb, gpio_port_pins_t pins)
+static void chip_reset(const struct device *gpio, struct gpio_callback *cb, gpio_port_pins_t pins)
File:boards/nordic/nrf9160dk/board.c
Line:99
You may want to run clang-format on this change:
-static void ads1x1x_conv_ready_cb(const struct device *gpio_dev,
- struct gpio_callback *cb,
- gpio_port_pins_t pins)
+static void ads1x1x_conv_ready_cb(const struct device *gpio_dev, struct gpio_callback *cb,
+ gpio_port_pins_t pins)
File:drivers/adc/adc_ads1x1x.c
Line:684
You may want to run clang-format on this change:
- gpio_init_callback(&data->gpio_cb, ads1x1x_conv_ready_cb,
- GPIO_BIT(config->alert_rdy.pin));
+ gpio_init_callback(&data->gpio_cb, ads1x1x_conv_ready_cb, GPIO_BIT(config->alert_rdy.pin));
File:drivers/adc/adc_ads1x1x.c
Line:730
You may want to run clang-format on this change:
-static void lmp90xxx_drdyb_callback(const struct device *port,
- struct gpio_callback *cb, gpio_port_pins_t pins)
+static void lmp90xxx_drdyb_callback(const struct device *port, struct gpio_callback *cb,
+ gpio_port_pins_t pins)
File:drivers/adc/adc_lmp90xxx.c
Line:712
You may want to run clang-format on this change:
-static void bt_spi_isr(const struct device *unused1,
- struct gpio_callback *unused2,
+static void bt_spi_isr(const struct device *unused1, struct gpio_callback *unused2,
File:drivers/bluetooth/hci/hci_spi_st.c
Line:175
You may want to run clang-format on this change:
-static void bt_spi_isr(const struct device *unused1,
- struct gpio_callback *unused2,
+static void bt_spi_isr(const struct device *unused1, struct gpio_callback *unused2,
File:drivers/bluetooth/hci/spi.c
Line:124
You may want to run clang-format on this change:
-static void mcp2515_int_gpio_callback(const struct device *dev,
- struct gpio_callback *cb, gpio_port_pins_t pins)
+static void mcp2515_int_gpio_callback(const struct device *dev, struct gpio_callback *cb,
+ gpio_port_pins_t pins)
File:drivers/can/can_mcp2515.c
Line:873
You may want to run clang-format on this change:
-#define AUXSRC_lposc LPOSC_CLKSRC
-#define AUXSRC_clk_hstx CLK_HSTX
-#define AUXSRC_otp_clk2fc OTP_CLK2FC
+#define AUXSRC_lposc LPOSC_CLKSRC
+#define AUXSRC_clk_hstx CLK_HSTX
+#define AUXSRC_otp_clk2fc OTP_CLK2FC
File:drivers/clock_control/clock_control_rpi_pico.c
Line:120
You may want to run clang-format on this change:
-#define AUXSTEM_clk_peri CLOCKS_CLK_PERI_CTRL_AUXSRC_VALUE_
+#define AUXSTEM_clk_peri CLOCKS_CLK_PERI_CTRL_AUXSRC_VALUE_
File:drivers/clock_control/clock_control_rpi_pico.c
Line:131
You may want to run clang-format on this change:
- rpi_pico_clkid_pll_sys,
- rpi_pico_clkid_gpin0,
- rpi_pico_clkid_gpin1,
- rpi_pico_clkid_pll_usb,
- rpi_pico_clkid_rosc_ph,
- rpi_pico_clkid_xosc,
- rpi_pico_clkid_clk_sys,
- rpi_pico_clkid_clk_usb,
- rpi_pico_clkid_clk_adc,
+ rpi_pico_clkid_pll_sys, rpi_pico_clkid_gpin0, rpi_pico_clkid_gpin1,
+ rpi_pico_clkid_pll_usb, rpi_pico_clkid_rosc_ph, rpi_pico_clkid_xosc,
+ rpi_pico_clkid_clk_sys, rpi_pico_clkid_clk_usb, rpi_pico_clkid_clk_adc,
File:drivers/clock_control/clock_control_rpi_pico.c
Line:325
You may want to run clang-format on this change:
- } else if (id == rpi_pico_clkid_clk_usb ||
- id == rpi_pico_clkid_clk_peri ||
+ } else if (id == rpi_pico_clkid_clk_usb || id == rpi_pico_clkid_clk_peri ||
id == rpi_pico_clkid_clk_adc ||
#if defined(RPI_PICO_CLKID_CLK_RTC)
id == rpi_pico_clkid_clk_rtc ||
#endif
- id == rpi_pico_clkid_clk_gpout0 ||
- id == rpi_pico_clkid_clk_gpout1 ||
- id == rpi_pico_clkid_clk_gpout2 ||
- id == rpi_pico_clkid_clk_gpout3) {
+ id == rpi_pico_clkid_clk_gpout0 || id == rpi_pico_clkid_clk_gpout1 ||
+ id == rpi_pico_clkid_clk_gpout2 || id == r
|
Artifacts
Produced during runtime
| Name | Size | |
|---|---|---|
|
compliance.xml
|
16 KB |
|