Skip to content

Commit

Permalink
manifest: bsim: Do not import but keep copy in submanifests/
Browse files Browse the repository at this point in the history
Due to a limitation in the west import feature,
a project cannot both have an import and be part of a group.
Moreover, when a project has an import and is not filtered
out, it is required for that project to be present
for most west commands to work.

As the bsim project is not filtered by default,
it causes trouble for users who never run a
west update but try to use west further.

To work around this issue, let's disable the import
in the bsim project, and instead copy its manifest
into the submanifests/ folder.

Having a replica of the babblesim manifes in the submanifest
folder is likely to cause some confusion in users,
wrt to which version of components they are using.
So whenever west supports both imports and groups, or another
simple and nicer way of working around this, it should be used.

Signed-off-by: Alberto Escolar Piedras <alberto.escolar.piedras@nordicsemi.no>
  • Loading branch information
aescolar committed Apr 28, 2023
1 parent 3e02d48 commit 119a263
Show file tree
Hide file tree
Showing 2 changed files with 91 additions and 2 deletions.
86 changes: 86 additions & 0 deletions submanifests/babblesim.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,86 @@
# Copyright 2023 Nordic Semiconductor ASA
# SPDX-License-Identifier: Apache-2.0
#
# west manifest file for BabbleSim
#
# Check https://babblesim.github.io/fetching.html for more information
#

manifest:
defaults:
remote: babblesim

remotes:
- name: babblesim
url-base: https://github.com/BabbleSim

self:
path: bsim

projects:
- name: babblesim_base
repo-path: base.git
path: bsim/components
revision: 02838ca04c4562e68dc876196828d8121679e537
groups:
- babblesim
- name: babblesim_ext_2G4_libPhyComv1
repo-path: ext_2G4_libPhyComv1.git
path: bsim/components/ext_2G4_libPhyComv1
revision: 9018113a362fa6c9e8f4b9cab9e5a8f12cc46b94
groups:
- babblesim
- name: babblesim_ext_2G4_phy_v1
repo-path: ext_2G4_phy_v1.git
path: bsim/components/ext_2G4_phy_v1
revision: cf2d86e736efac4f12fad5093ed2da2c5b406156
groups:
- babblesim
- name: babblesim_ext_2G4_channel_NtNcable
repo-path: ext_2G4_channel_NtNcable.git
path: bsim/components/ext_2G4_channel_NtNcable
revision: 20a38c997f507b0aa53817aab3d73a462fff7af1
groups:
- babblesim
- name: babblesim_ext_2G4_channel_multiatt
repo-path: ext_2G4_channel_multiatt.git
path: bsim/components/ext_2G4_channel_multiatt
revision: e09bc2d14b1975f969ad19c6ed23eb20e5dc3d09
groups:
- babblesim
- name: babblesim_ext_2G4_modem_magic
repo-path: ext_2G4_modem_magic.git
path: bsim/components/ext_2G4_modem_magic
revision: cb70771794f0bf6f262aa474848611c68ae8f1ed
groups:
- babblesim
- name: babblesim_ext_2G4_modem_BLE_simple
repo-path: ext_2G4_modem_BLE_simple.git
path: bsim/components/ext_2G4_modem_BLE_simple
revision: ce975a3259fd0dd761d371b60435242d54794bad
groups:
- babblesim
- name: babblesim_ext_2G4_device_burst_interferer
repo-path: ext_2G4_device_burst_interferer.git
path: bsim/components/ext_2G4_device_burst_interferer
revision: 5b5339351d6e6a2368c686c734dc8b2fc65698fc
groups:
- babblesim
- name: babblesim_ext_2G4_device_WLAN_actmod
repo-path: ext_2G4_device_WLAN_actmod.git
path: bsim/components/ext_2G4_device_WLAN_actmod
revision: 9cb6d8e72695f6b785e57443f0629a18069d6ce4
groups:
- babblesim
- name: babblesim_ext_2G4_device_playback
repo-path: ext_2G4_device_playback.git
path: bsim/components/ext_2G4_device_playback
revision: 85c645929cf1ce995d8537107d9dcbd12ed64036
groups:
- babblesim
- name: babblesim_ext_libCryptov1
repo-path: ext_libCryptov1.git
path: bsim/components/ext_libCryptov1
revision: eed6d7038e839153e340bd333bc43541cb90ba64
groups:
- babblesim
7 changes: 5 additions & 2 deletions west.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,11 @@ manifest:
- name: bsim
repo-path: babblesim-manifest
revision: 908ffde6298a937c6549dbfa843a62caab26bfc5
import:
path-prefix: tools
path: bsim
# Note: Due to a limitation in west's group import filtering,
# the babblesim manifest used by default is kept in submanifests/babblesim.yml
groups:
- babblesim
- name: canopennode
revision: dec12fa3f0d790cafa8414a4c2930ea71ab72ffd
path: modules/lib/canopennode
Expand Down

0 comments on commit 119a263

Please sign in to comment.