Skip to content

Commit

Permalink
twister: Always change skip to error on integration platforms
Browse files Browse the repository at this point in the history
Before only with --integration such skips were changed to errors.
This hinders issues when twister is call with --all flag in CI
and new skips on integration platforms are not caught. Then those
skips cause errors in other PRs when --integration was used.

Signed-off-by: Maciej Perkowski <Maciej.Perkowski@nordicsemi.no>
  • Loading branch information
PerMac committed Sep 15, 2023
1 parent 15c733a commit 12df876
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions scripts/pylib/twister/twisterlib/testplan.py
Original file line number Diff line number Diff line change
Expand Up @@ -1016,8 +1016,8 @@ def _create_build_dir_link(self, links_dir_path, instance):


def change_skip_to_error_if_integration(options, instance):
''' If integration mode is on all skips on integration_platforms are treated as errors.'''
if options.integration and instance.platform.name in instance.testsuite.integration_platforms \
''' All skips on integration_platforms are treated as errors.'''
if instance.platform.name in instance.testsuite.integration_platforms \
and "quarantine" not in instance.reason.lower():
# Do not treat this as error if filter type is command line
filters = {t['type'] for t in instance.filters}
Expand Down

0 comments on commit 12df876

Please sign in to comment.