logging: Fix LOG_OUTPUT dependency

When CONFIG_LOG_OUTPUT is set, it indicates that logging strings are formatted by the application (using log_output module). It is not needed when backend works in the dictionary mode. So far LOG_OUTPUT was set also when dictionary mode was used and that prevented removing of the logging strings from binary which is an important feature of the dictionary logging. Signed-off-by: Krzysztof Chruściński <krzysztof.chruscinski@nordicsemi.no>
zephyrproject-rtos · Oct 9, 2024 · 8652e8e · 8652e8e
1 parent df683fd
commit 8652e8e
Show file tree

Hide file tree

Showing 14 changed files with 1 addition and 13 deletions.
diff --git a/subsys/logging/Kconfig.template.log_format_config b/subsys/logging/Kconfig.template.log_format_config
@@ -7,6 +7,7 @@ choice "LOG_BACKEND_$(backend)_OUTPUT"
 
 config LOG_BACKEND_$(backend)_OUTPUT_TEXT
 	bool "Text"
+	select LOG_OUTPUT
 	help
 	  Output in text.
 

diff --git a/subsys/logging/backends/Kconfig.adsp b/subsys/logging/backends/Kconfig.adsp
@@ -4,7 +4,6 @@
 config LOG_BACKEND_ADSP
 	bool "Intel ADSP buffer backend"
 	depends on SOC_FAMILY_INTEL_ADSP
-	select LOG_OUTPUT
 	select LOG_BACKEND_SUPPORTS_FORMAT_TIMESTAMP
 	help
 	  Enable backend for the host trace protocol of the Intel ADSP

diff --git a/subsys/logging/backends/Kconfig.adsp_mtrace b/subsys/logging/backends/Kconfig.adsp_mtrace
@@ -4,7 +4,6 @@
 config LOG_BACKEND_ADSP_MTRACE
 	bool "Intel ADSP mtrace backend"
 	depends on SOC_FAMILY_INTEL_ADSP
-	select LOG_OUTPUT
 	select LOG_BACKEND_SUPPORTS_FORMAT_TIMESTAMP
 	help
 	  Provide a logging backend which writes to SRAM window

diff --git a/subsys/logging/backends/Kconfig.ble b/subsys/logging/backends/Kconfig.ble
@@ -5,7 +5,6 @@ config LOG_BACKEND_BLE
 	bool "Bluetooth Low Energy (BLE) backend"
 	depends on BT
 	depends on LOG_PROCESS_THREAD_STACK_SIZE>=2048
-	select LOG_OUTPUT
 	select EXPERIMENTAL
 	help
 	  Backend that sends log messages over Bluetooth LE Notifications. This

diff --git a/subsys/logging/backends/Kconfig.efi_console b/subsys/logging/backends/Kconfig.efi_console
@@ -4,7 +4,6 @@
 config LOG_BACKEND_EFI_CONSOLE
 	bool "EFI_CONSOLE backend"
 	depends on X86_EFI_CONSOLE
-	select LOG_OUTPUT
 	default y if !UART_CONSOLE
 	help
 	  When enabled backend is using EFI CONSOLE to output logs.

diff --git a/subsys/logging/backends/Kconfig.fs b/subsys/logging/backends/Kconfig.fs
@@ -4,7 +4,6 @@
 config LOG_BACKEND_FS
 	bool "File system backend"
 	depends on FILE_SYSTEM
-	select LOG_OUTPUT
 	select LOG_BACKEND_SUPPORTS_FORMAT_TIMESTAMP
 	help
 	  When enabled, backend is using the configured file system to output logs.

diff --git a/subsys/logging/backends/Kconfig.native_posix b/subsys/logging/backends/Kconfig.native_posix
@@ -5,7 +5,6 @@ config LOG_BACKEND_NATIVE_POSIX
 	bool "Native backend"
 	depends on ARCH_POSIX
 	default y
-	select LOG_OUTPUT
 	select LOG_BACKEND_SUPPORTS_FORMAT_TIMESTAMP
 	help
 	  Enable backend in native_posix

diff --git a/subsys/logging/backends/Kconfig.net b/subsys/logging/backends/Kconfig.net
@@ -6,7 +6,6 @@
 config LOG_BACKEND_NET
 	bool "Networking backend"
 	depends on NETWORKING && (NET_UDP || NET_TCP) && !LOG_MODE_IMMEDIATE
-	select LOG_OUTPUT
 	help
 	  Send syslog messages to network server.
 	  See RFC 5424 (syslog protocol) and RFC 5426 (syslog over UDP) and

diff --git a/subsys/logging/backends/Kconfig.rtt b/subsys/logging/backends/Kconfig.rtt
@@ -6,7 +6,6 @@ config LOG_BACKEND_RTT
 	depends on USE_SEGGER_RTT
 	default y if !SHELL_BACKEND_RTT
 	select SEGGER_RTT_CUSTOM_LOCKING
-	select LOG_OUTPUT
 	select LOG_BACKEND_SUPPORTS_FORMAT_TIMESTAMP
 	help
 	  When enabled, backend will use RTT for logging. This backend works on a per

diff --git a/subsys/logging/backends/Kconfig.semihost b/subsys/logging/backends/Kconfig.semihost
@@ -4,7 +4,6 @@
 config LOG_BACKEND_SEMIHOST
 	bool "Semihost as backend"
 	depends on SEMIHOST
-	select LOG_OUTPUT
 	select LOG_BACKEND_SUPPORTS_FORMAT_TIMESTAMP
 	help
 	  Enable backend in semihost (using host stdout)

diff --git a/subsys/logging/backends/Kconfig.spinel b/subsys/logging/backends/Kconfig.spinel
@@ -5,7 +5,6 @@ config LOG_BACKEND_SPINEL
 	bool "OpenThread dedicated Spinel protocol backend"
 	depends on !LOG_BACKEND_UART
 	depends on NET_L2_OPENTHREAD
-	select LOG_OUTPUT
 	help
 	  When enabled, backend will use OpenThread dedicated SPINEL protocol for logging.
 	  This protocol is byte oriented and wraps given messages into serial frames.

diff --git a/subsys/logging/backends/Kconfig.swo b/subsys/logging/backends/Kconfig.swo
@@ -4,7 +4,6 @@
 config LOG_BACKEND_SWO
 	bool "Serial Wire Output (SWO) backend"
 	depends on HAS_SWO
-	select LOG_OUTPUT
 	select LOG_BACKEND_SUPPORTS_FORMAT_TIMESTAMP
 	help
 	  When enabled, backend will use SWO for logging.

diff --git a/subsys/logging/backends/Kconfig.uart b/subsys/logging/backends/Kconfig.uart
@@ -5,7 +5,6 @@ config LOG_BACKEND_UART
 	bool "UART backend"
 	depends on UART_CONSOLE
 	default y if !SHELL_BACKEND_SERIAL && !SHELL_BACKEND_RTT
-	select LOG_OUTPUT
 	select LOG_BACKEND_SUPPORTS_FORMAT_TIMESTAMP
 	help
 	  When enabled backend is using UART to output logs.

diff --git a/subsys/logging/backends/Kconfig.xtensa_sim b/subsys/logging/backends/Kconfig.xtensa_sim
@@ -5,7 +5,6 @@ config LOG_BACKEND_XTENSA_SIM
 	bool "Xtensa simulator backend"
 	depends on SOC_XTENSA_SAMPLE_CONTROLLER || SOC_XTENSA_DC233C || SOC_FAMILY_INTEL_ADSP
 	default y if SOC_XTENSA_SAMPLE_CONTROLLER || SOC_XTENSA_DC233C
-	select LOG_OUTPUT
 	select LOG_BACKEND_SUPPORTS_FORMAT_TIMESTAMP
 	help
 	  Enable backend in xtensa simulator