Skip to content

Commit

Permalink
llext: remove the "modules_enabled" tests
Browse files Browse the repository at this point in the history
These tests are simple copies of the existing tests with the addition of
the CONFIG_MODULES=y option. This different Kconfig setting has no
practical effect on the code, and the tests are therefore redundant.

Remove them to halve the number of tests.

Signed-off-by: Luca Burelli <l.burelli@arduino.cc>
  • Loading branch information
pillo79 committed Jun 13, 2024
1 parent 59931ec commit 9eb02d1
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 92 deletions.
12 changes: 0 additions & 12 deletions tests/subsys/llext/simple/Kconfig

This file was deleted.

85 changes: 5 additions & 80 deletions tests/subsys/llext/simple/testcase.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,9 @@ common:
- arm
- xtensa
platform_exclude:
- apollo4p_evb
- apollo4p_blue_kxr_evb
- numaker_pfm_m487 # See #63167
- apollo4p_evb # See #73443
- apollo4p_blue_kxr_evb # See #73443
- numaker_pfm_m487 # See #63167

tests:
# While there is in practice no value in compiling subsys/llext/*.c
Expand Down Expand Up @@ -36,50 +36,14 @@ tests:
extra_configs:
- arch:arm:CONFIG_ARM_MPU=n
- CONFIG_LLEXT_STORAGE_WRITABLE=y
llext.simple.modules_enabled_writable:
filter: not CONFIG_MPU and not CONFIG_MMU
platform_key:
- simulation
- arch
platform_exclude:
- qemu_cortex_a9 # MMU
extra_configs:
- arch:arm:CONFIG_ARM_MPU=n
- CONFIG_MODULES=y
- CONFIG_LLEXT_STORAGE_WRITABLE=y
- CONFIG_LLEXT_TEST_HELLO=m
llext.simple.modules_enabled_writable_relocatable:
llext.simple.writable_relocatable:
arch_exclude: arm arm64
filter: not CONFIG_MPU and not CONFIG_MMU
integration_platforms:
- qemu_xtensa
extra_configs:
- CONFIG_MODULES=y
- CONFIG_LLEXT_STORAGE_WRITABLE=y
- CONFIG_LLEXT_TYPE_ELF_RELOCATABLE=y
- CONFIG_LLEXT_TEST_HELLO=m
llext.simple.modules_enabled_readonly:
filter: not CONFIG_MPU and not CONFIG_MMU
arch_exclude: xtensa # for now
platform_key:
- simulation
- arch
platform_exclude:
- qemu_cortex_a9 # MMU
extra_configs:
- arch:arm:CONFIG_ARM_MPU=n
- CONFIG_MODULES=y
- CONFIG_LLEXT_TEST_HELLO=m
llext.simple.modules_enabled_readonly_mpu:
filter: CONFIG_ARCH_HAS_USERSPACE
arch_exclude: xtensa # for now
platform_key:
- simulation
- arch
extra_configs:
- CONFIG_USERSPACE=y
- CONFIG_MODULES=y
- CONFIG_LLEXT_TEST_HELLO=m
llext.simple.readonly_slid_linking:
arch_exclude: xtensa # for now
filter: not CONFIG_MPU and not CONFIG_MMU and not CONFIG_SOC_SERIES_S32ZE
Expand All @@ -100,51 +64,12 @@ tests:
extra_configs:
- arch:arm:CONFIG_ARM_MPU=n
- CONFIG_LLEXT_STORAGE_WRITABLE=y
llext.simple.modules_enabled_writable_slid_linking:
filter: not CONFIG_MPU and not CONFIG_MMU
platform_key:
- simulation
- arch
platform_exclude:
- qemu_cortex_a9 # MMU
extra_configs:
- arch:arm:CONFIG_ARM_MPU=n
- CONFIG_MODULES=y
- CONFIG_LLEXT_STORAGE_WRITABLE=y
- CONFIG_LLEXT_TEST_HELLO=m
- CONFIG_LLEXT_EXPORT_BUILTINS_BY_SLID=y
llext.simple.modules_enabled_writable_relocatable_slid_linking:
llext.simple.writable_relocatable_slid_linking:
arch_exclude: arm arm64
filter: not CONFIG_MPU and not CONFIG_MMU
integration_platforms:
- qemu_xtensa
extra_configs:
- CONFIG_MODULES=y
- CONFIG_LLEXT_STORAGE_WRITABLE=y
- CONFIG_LLEXT_TYPE_ELF_RELOCATABLE=y
- CONFIG_LLEXT_TEST_HELLO=m
- CONFIG_LLEXT_EXPORT_BUILTINS_BY_SLID=y
llext.simple.modules_enabled_readonly_slid_linking:
filter: not CONFIG_MPU and not CONFIG_MMU
arch_exclude: xtensa # for now
platform_key:
- simulation
- arch
platform_exclude:
- qemu_cortex_a9 # MMU
extra_configs:
- arch:arm:CONFIG_ARM_MPU=n
- CONFIG_MODULES=y
- CONFIG_LLEXT_TEST_HELLO=m
- CONFIG_LLEXT_EXPORT_BUILTINS_BY_SLID=y
llext.simple.modules_enabled_readonly_mpu_slid_linking:
filter: CONFIG_ARCH_HAS_USERSPACE
arch_exclude: xtensa # for now
platform_key:
- simulation
- arch
extra_configs:
- CONFIG_USERSPACE=y
- CONFIG_MODULES=y
- CONFIG_LLEXT_TEST_HELLO=m
- CONFIG_LLEXT_EXPORT_BUILTINS_BY_SLID=y

0 comments on commit 9eb02d1

Please sign in to comment.