Skip to content

Commit

Permalink
logging: frontend: stmesp: Do not append strings when not needed
Browse files Browse the repository at this point in the history
Currently we can assume that flpr and ppr cores are always owned by
cpuapp. In that case, cpuapp (which processes ETR buffer content) has
access to the memory where logging strings from ppr and flpr are
located. Those strings do not need to be appended to the message
which is written to the STM (in case of standalone configuration).
This approach reduced logging time, e.g. logging a message with
one argument takes 1.8us on cpuapp and 6.3us on cpurad.

This setting applies only to the case when cpuapp is the owner
of those co-oprocessors and shall be updated if that becomes
configurable but currently there are no means to detect core
owner.

Signed-off-by: Krzysztof Chruściński <krzysztof.chruscinski@nordicsemi.no>
  • Loading branch information
nordic-krch authored and fabiobaltieri committed Sep 27, 2024
1 parent 8e22222 commit c2454f2
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion subsys/logging/frontends/Kconfig
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,8 @@ config LOG_FRONTEND_STMESP_DICT

config LOG_FRONTEND_STMESP_FSC
bool "Send fully self-contained messages"
select LOG_MSG_APPEND_RO_STRING_LOC if !NRF_ETR
select LOG_MSG_APPEND_RO_STRING_LOC if (!NRF_ETR && !SOC_NRF54H20_CPUPPR && \
!SOC_NRF54H20_CPUFLPR)

config LOG_FRONTEND_STMESP_FLUSH_COUNT
int "Number of flushing words"
Expand Down

0 comments on commit c2454f2

Please sign in to comment.