modem: cmux: apply static const to reduce RAM usage

Added `static const` to various `struct modem_pipe_api` and `frame` in `modem_cmux_connect_handler` to make these structures immutable and reduce RAM usage. Corrected a typo, changing "consequtive" to "consecutive". Signed-off-by: Pisit Sawangvonganan <pisit@ndrsolution.com>
zephyrproject-rtos · Jul 27, 2024 · c43b20e · c43b20e
1 parent ba30e7b
commit c43b20e
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 6 deletions.
diff --git a/subsys/modem/backends/modem_backend_tty.c b/subsys/modem/backends/modem_backend_tty.c
@@ -103,7 +103,7 @@ static int modem_backend_tty_close(void *data)
 	return 0;
 }
 
-struct modem_pipe_api modem_backend_tty_api = {
+static const struct modem_pipe_api modem_backend_tty_api = {
 	.open = modem_backend_tty_open,
 	.transmit = modem_backend_tty_transmit,
 	.receive = modem_backend_tty_receive,

diff --git a/subsys/modem/backends/modem_backend_uart_async.c b/subsys/modem/backends/modem_backend_uart_async.c
@@ -269,7 +269,7 @@ static int modem_backend_uart_async_close(void *data)
 	return 0;
 }
 
-struct modem_pipe_api modem_backend_uart_async_api = {
+static const struct modem_pipe_api modem_backend_uart_async_api = {
 	.open = modem_backend_uart_async_open,
 	.transmit = modem_backend_uart_async_transmit,
 	.receive = modem_backend_uart_async_receive,

diff --git a/subsys/modem/backends/modem_backend_uart_isr.c b/subsys/modem/backends/modem_backend_uart_isr.c
@@ -233,7 +233,7 @@ static int modem_backend_uart_isr_close(void *data)
 	return 0;
 }
 
-struct modem_pipe_api modem_backend_uart_isr_api = {
+static const struct modem_pipe_api modem_backend_uart_isr_api = {
 	.open = modem_backend_uart_isr_open,
 	.transmit = modem_backend_uart_isr_transmit,
 	.receive = modem_backend_uart_isr_receive,

diff --git a/subsys/modem/modem_cmux.c b/subsys/modem/modem_cmux.c
@@ -740,7 +740,7 @@ static void modem_cmux_process_received_byte(struct modem_cmux *cmux, uint8_t by
 
 	case MODEM_CMUX_RECEIVE_STATE_RESYNC:
 		/*
-		 * Allow any number of consequtive flags (0xF9).
+		 * Allow any number of consecutive flags (0xF9).
 		 * 0xF9 could also be a valid address field for DLCI 62.
 		 */
 		if (byte == 0xF9) {
@@ -992,7 +992,7 @@ static void modem_cmux_connect_handler(struct k_work *item)
 
 	cmux->state = MODEM_CMUX_STATE_CONNECTING;
 
-	struct modem_cmux_frame frame = {
+	static const struct modem_cmux_frame frame = {
 		.dlci_address = 0,
 		.cr = true,
 		.pf = true,
@@ -1154,7 +1154,7 @@ static int modem_cmux_dlci_pipe_api_close(void *data)
 	return ret;
 }
 
-struct modem_pipe_api modem_cmux_dlci_pipe_api = {
+static const struct modem_pipe_api modem_cmux_dlci_pipe_api = {
 	.open = modem_cmux_dlci_pipe_api_open,
 	.transmit = modem_cmux_dlci_pipe_api_transmit,
 	.receive = modem_cmux_dlci_pipe_api_receive,