Skip to content

Commit

Permalink
cmake: dts: Use temporary file for dts.cmake with sysbuild
Browse files Browse the repository at this point in the history
Uses a temporary file when sysbuild is being used for images then
uses CMake to copy to the correct file if it has changed. This
prevents a ping-pong of configuring and building cycle when nothing
has changed and there is sysbuild code which loads in the
devicetree data from an image

Signed-off-by: Jamie McCrae <jamie.mccrae@nordicsemi.no>
  • Loading branch information
nordicjm committed Nov 13, 2024
1 parent 049b243 commit f230669
Showing 1 changed file with 8 additions and 1 deletion.
9 changes: 8 additions & 1 deletion cmake/modules/dts.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -349,17 +349,24 @@ endif()
#
# Run GEN_DTS_CMAKE_SCRIPT.
#
# A temporary file is used copied to the original file if it differs, this prevents a cycle when
# sysbuild is used of configuring and building multiple times due to the dts.cmake file of images
# having a newer modification time than the sysbuild build.ninja file, despite the output having
# not changed
#
set(dts_cmake_tmp ${DTS_CMAKE}_tmp)

execute_process(
COMMAND ${PYTHON_EXECUTABLE} ${GEN_DTS_CMAKE_SCRIPT}
--edt-pickle ${EDT_PICKLE}
--cmake-out ${DTS_CMAKE}
--cmake-out ${dts_cmake_tmp}
WORKING_DIRECTORY ${PROJECT_BINARY_DIR}
RESULT_VARIABLE ret
)
if(NOT "${ret}" STREQUAL "0")
message(FATAL_ERROR "gen_dts_cmake.py failed with return code: ${ret}")
else()
file(COPY_FILE ${dts_cmake_tmp} ${DTS_CMAKE} ONLY_IF_DIFFERENT)
message(STATUS "Including generated dts.cmake file: ${DTS_CMAKE}")
include(${DTS_CMAKE})
endif()
Expand Down

0 comments on commit f230669

Please sign in to comment.