-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drivers: ADC: Introduce gd32 adc driver #42215
Conversation
When compile the I guess this issue caused by the ADC interface number. GD32F350 have one ADC interface, but GD32F450 and GD32VF103 have more than one ADC interface. And I use the Warning output: warning.txt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, a few minor comments. Boards board.yaml
should also be updated to include adc
on the supported list.
8b825df
to
ac8e65d
Compare
Add support for gd32 adc. Signed-off-by: HaiLong Yang <hailong.yang@brainco.cn>
@nandojve Please help to confirm the new shared irq implement, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @cameled,
I found more two small fixes. Overall is a very nice work!
This driver based on single conversion mode with regular channel. Signed-off-by: HaiLong Yang <hailong.yang@brainco.cn>
This add adc support for gd32f350r_eval, gd32f450i_eval and gd32vf103v_eval boards. Signed-off-by: HaiLong Yang <hailong.yang@brainco.cn>
This add gd32 boards support for the adc sample. Signed-off-by: HaiLong Yang <hailong.yang@brainco.cn>
Add cameled as gd32 platform collaborator. Signed-off-by: HaiLong Yang <hailong.yang@brainco.cn>
DTS node address should use lower case. This fix an incorrect gd32f403 usart3 node address. Signed-off-by: HaiLong Yang <hailong.yang@brainco.cn>
Add an initial support for gd32 adc interface.
This driver based on single conversion mode with regular channel.
Test with
samples/drivers/adc
sample on gd32f350r_eval, gd32f450i_eval and gd32vf103v_eval boards.work list: