Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

boards: xtensa: Add support for Lolin S2 Mini #56744

Merged
merged 1 commit into from
Nov 6, 2023
Merged

boards: xtensa: Add support for Lolin S2 Mini #56744

merged 1 commit into from
Nov 6, 2023

Conversation

mfischer
Copy link
Contributor

Add support for LOLIN S2 Mini board, a cheap board also sold as Wemos S2 Mini.

@zephyrbot zephyrbot added the platform: ESP32 Espressif ESP32 label Apr 12, 2023
@MaureenHelm
Copy link
Member

@sylvioalves ping

@mfischer
Copy link
Contributor Author

mfischer commented May 3, 2023

@sylvioalves it seems the failing test fails also with west build -p -b esp32s2_saola -T tests/lib/heap/libraries.heap ideas?

@mfischer
Copy link
Contributor Author

mfischer commented May 3, 2023

@sylvioalves it seems the failing test fails also with west build -p -b esp32s2_saola -T tests/lib/heap/libraries.heap ideas?

Hrmmm ... Investigation showed this test was disabled for that board, let me do the same :)

@mfischer mfischer closed this May 3, 2023
@mfischer mfischer reopened this May 3, 2023
marekmatej
marekmatej previously approved these changes May 15, 2023
View reviewed changes
@mfischer
Copy link
Contributor Author

@marekmatej @sylvioalves ping :)

@marekmatej
Copy link

Please note upcoming changes in boards/soc Kconfig #58454

@mfischer
Copy link
Contributor Author

Please note upcoming changes in boards/soc Kconfig #58454

Should we wait for this or can this go in before?

@marekmatej
Copy link

Please note upcoming changes in boards/soc Kconfig #58454

Should we wait for this or can this go in before?

If this is merged prior to SOC refactor, I'd need to update your work afterward. So I'd prefer if you can wait a little more.

@cfriedt
Copy link
Member

cfriedt commented Aug 3, 2023

dev-review:
@mfischer - #58454 is merged, please update this if necessary
@sylvioalves - re-ping

@mfischer
Copy link
Contributor Author

mfischer commented Aug 4, 2023

dev-review: @mfischer - #58454 is merged, please update this if necessary @sylvioalves - re-ping

Rebased and updated. samples/basic/blinky and samples/hello_world still work

@MaureenHelm
Copy link
Member

@sylvioalves please revisit

@MaureenHelm
Copy link
Member

@mfischer can you please have a look at the review comments?

marekmatej
marekmatej previously approved these changes Oct 26, 2023
View reviewed changes
@sylvioalves
Copy link
Collaborator

LGTM. Just waiting previous comments to be addressed.

@mfischer mfischer force-pushed the esp32s2_lolin_mini branch 6 times, most recently from 3422dfe to 6c21af6 Compare October 31, 2023 04:23
@mfischer
boards: xtensa: Add support for Lolin S2 Mini
7976746 
Add support for LOLIN S2 Mini board, a cheap board
also sold as Wemos S2 Mini.

Signed-off-by: Moritz Fischer <moritzf@google.com>
@mfischer
Copy link
Contributor Author

mfischer commented Nov 1, 2023

@sylvioalves ping

@carlescufi carlescufi merged commit 016a113 into zephyrproject-rtos:main Nov 6, 2023
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sylvioalves sylvioalves sylvioalves approved these changes

@kartben kartben kartben left review comments

@marekmatej marekmatej marekmatej approved these changes

@nashif nashif Awaiting requested review from nashif

@dcpleung dcpleung Awaiting requested review from dcpleung

@LucasTambor LucasTambor Awaiting requested review from LucasTambor

@uLipe uLipe Awaiting requested review from uLipe

Assignees

@sylvioalves sylvioalves

Labels
platform: ESP32 Espressif ESP32
Projects
Dev Review
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@mfischer @MaureenHelm @marekmatej @cfriedt @sylvioalves @kartben @carlescufi @zephyrbot