Bluetooth: GMAP: Add initial implementation of GMAP #57032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thalley
force-pushed
the
gmap_iop
branch
3 times, most recently
from
5610d13
to
12d87d4
Compare
|
The implementation of TMAP in #56686 and this should be made similar. TBD which changes to be done by either. |
Thalley
force-pushed
the
gmap_iop
branch
23 times, most recently
from
dcdbe23
to
cfd6e0a
Compare
Thalley
force-pushed
the
gmap_iop
branch
2 times, most recently
from
808659f
to
3255e5d
Compare
Thalley
force-pushed
the
gmap_iop
branch
3 times, most recently
from
466c1cf
to
77c33d2
Compare
larsgk
requested changes
Sep 20, 2023
|
|
||
| err = bt_bap_unicast_client_register_cb(&unicast_client_cbs); | ||
| if (err != 0) { | ||
| FAIL("Failed to register CAP callbacks (err %d)\n", err); |
| } | ||
|
|
||
| if (src_ep_cnt != src_cnt) { | ||
| FAIL("Source endpoint and stream count mismatch: %zu != %zu\n", src_ep_cnt, |
Comment on lines
787
to
788
| /* Set all endpoints from multiple connections in a single array, and verify that the known | ||
| * endpoints matches the audio configuration | ||
| */ | ||
| for (size_t i = 0U; i < param->conn_cnt; i++) { | ||
| for (size_t j = 0U; j < param->snk_cnt[i]; j++) { | ||
| snk_cnt++; | ||
| } | ||
|
|
||
| for (size_t j = 0U; j < param->src_cnt[i]; j++) { | ||
| src_cnt++; | ||
| } | ||
| } |
There was a problem hiding this comment.
Comment and code doesn't seem to match for me for this block.
subsys/bluetooth/audio/shell/gmap.c
Outdated
| static int cmd_gmap_ac_14(const struct shell *sh, size_t argc, char **argv) | ||
| { | ||
| const struct bap_broadcast_ac_param param = { | ||
| .name = "AC_13", |
larsgk
previously approved these changes
Sep 28, 2023
|
@fredrikdanebjer @kruithofa @cvinayak @MariuszSkamra @Casper-Bonde-Bose it would good to get this (experimental) feature into 3.5 if possible - If you can please review ASAP before the feature freeze tomorrow. |
Thalley
force-pushed
the
gmap_iop
branch
2 times, most recently
from
f0008bc
to
798632c
Compare
Thalley
force-pushed
the
gmap_iop
branch
3 times, most recently
from
ea6f97e
to
b35d24d
Compare
Add initial implementation of Gaming Audio Profile (GMAP). This is a top layer profile in the LE Audio stack, designed for low latency audio ideal for gaming. Signed-off-by: Emil Gydesen <emil.gydesen@nordicsemi.no>
Add the GMAP shell module with support for running the various audio configurations in an easy way. Signed-off-by: Emil Gydesen <emil.gydesen@nordicsemi.no>
Add BSIM testing of GMAP, with all spec-specified audio configuration combinations added and tested. Signed-off-by: Emil Gydesen <emil.gydesen@nordicsemi.no>
larsgk
approved these changes
Nov 14, 2023
kruithofa
approved these changes
Dec 11, 2023
msmttchr
reviewed
Dec 13, 2023
| @@ -622,6 +622,8 @@ static void connected(struct bt_conn *conn, uint8_t err) | |||
| } | |||
| } | |||
|
|
|||
| default_conn = bt_conn_ref(conn); | |||
There was a problem hiding this comment.
@Thalley, I think this line has been inserted by mistake as it does call twice bt_conn_ref. Is this intentional?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add initial implementation of GMAP.
This comes with the implementation of all GMAP roles, as well as BSIM and shell support.
Samples are not yet implemented, but may be added as part of this PR or a subsequent PR.