Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

soc: esp32*: do not enable HAS_DYNAMIC_DEVICE_HANDLES #59229

Merged
merged 1 commit into from
Jun 15, 2023

Conversation

gmarull
Copy link
Member

@gmarull gmarull commented Jun 14, 2023

It doesn't make sense to select this option at SoC level. This feature is meant for subsystems/modules that need device handles to be modifiable at runtime.

It doesn't make sense to select this option at SoC level. This feature
is meant for subsystems/modules that need device handles to be
modifiable at runtime.

Signed-off-by: Gerard Marull-Paretas <gerard.marull@nordicsemi.no>
@gmarull gmarull added the bug The issue is a bug, or the PR is fixing a bug label Jun 14, 2023
@zephyrbot zephyrbot added area: RISCV RISCV Architecture (32-bit & 64-bit) platform: ESP32 Espressif ESP32 labels Jun 14, 2023
@gmarull gmarull added this to the v3.4.0 milestone Jun 14, 2023
@marekmatej
Copy link

hi @gmarull, thanks for your finding! Please note we are refactoring the soc folders for all ESP32 chips, where that option is moved to the common folder but could be removed entirely. #58454

@gmarull
Copy link
Member Author

gmarull commented Jun 14, 2023

hi @gmarull, thanks for your finding! Please note we are refactoring the soc folders for all ESP32 chips, where that option is moved to the common folder but could be removed entirely. #58454

It should be removed, but since this is a bug it can go in now.

@nashif nashif merged commit c59b57c into zephyrproject-rtos:main Jun 15, 2023
@gmarull gmarull deleted the esp32-dyn-handles branch June 15, 2023 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: RISCV RISCV Architecture (32-bit & 64-bit) bug The issue is a bug, or the PR is fixing a bug platform: ESP32 Espressif ESP32
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants