soc: adsp: cmake: disable sign.py when CONFIG_KERNEL_BIN_NAME is used #59726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
De-duplicate the `if target in ('imx8', 'imx8m'):` copy/paste/diverge
before someone updates one and not the other. Also better to define
bootloader always.
Zero functional change.
Signed-off-by: Marc Herbert <marc.herbert@intel.com>
sign.py, sof/scripts/xtensa-build-zephyr.py and other SOF infrastructure do not support the (rarely used) CONFIG_KERNEL_BIN_NAME so stop pretending they do. This fixes the build error below reported in zephyrproject-rtos#59603 when CONFIG_KERNEL_BIN_NAME is used: ``` zephyr/zephyr.elf', needed by 'zephyr/zephyr.ri', missing and no known rule to make it ``` Note `rimage` is _still_ optional, even when CONFIG_KERNEL_BIN_NAME is not used. As before, to avoid using rimage: - make sure it's not in your PATH - west config -d rimage.path Signed-off-by: Marc Herbert <marc.herbert@intel.com>
marc-hb
requested review from
mbolivar-nordic,
dcpleung,
andyross and
nashif
as code owners
zephyrbot
added
area: West
zephyrbot
requested review from
aborisovich,
carlescufi,
ceolin,
jxstelter,
kv2019i,
lgirdwood,
lyakh,
MaureenHelm,
softwarecki,
swinslow and
tmleman
This was referenced Jun 23, 2023
|
Replaced with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This alternative competes with
sign.py, sof/scripts/xtensa-build-zephyr.py and other SOF infrastructure
do not support the (rarely used) CONFIG_KERNEL_BIN_NAME so stop
pretending they do.
This fixes the build error below reported in #59603 when
CONFIG_KERNEL_BIN_NAME is used:
Note
rimageis still optional, even when CONFIG_KERNEL_BIN_NAME isnot used. As before, to avoid using rimage:
Signed-off-by: Marc Herbert marc.herbert@intel.com